Skip to content

fix: map moves to origin when double-clicking #2651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: map moves to origin when double-clicking #2651

wants to merge 3 commits into from
+10 −8

Conversation

@Anders2303
Copy link
Collaborator

@Anders2303 Anders2303 commented Oct 24, 2025 •
edited
Loading

Resolves #2642

My changes done in #2621 accidentally forgot to return the scaled coordinate after picking, which was causing the map to move to origin on double-clicks

@Anders2303 Anders2303 requested a review from w1nklr October 24, 2025 13:56
w1nklr
w1nklr reviewed Oct 27, 2025
View reviewed changes
hkfb
hkfb reviewed Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@hkfb hkfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A simple test could be a new story displaying a map and using the play function to implement a double click. There are several example stories using play to test story behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hkfb hkfb hkfb left review comments

@w1nklr w1nklr w1nklr left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SubsurfaceViewer / Map - double moves anchor to origin

3 participants

@Anders2303 @hkfb @w1nklr