Skip to content

Conversation

jnross
Copy link
Contributor

@jnross jnross commented Aug 25, 2023

I investigated the CI failures and discovered it was a non-zero exit code from a call to apt-get update that was causing the workflow to fail. In order to fix this, I had to fork the gha-ubuntu-cross repo and apply the fix there. I'm working to get this fix upstreamed in cyberjunk/gha-ubuntu-cross#6. Once it is, we can revert this reference back to the original repo.

I also fixed a clippy warning that was added 1.72.0. https://rust-lang.github.io/rust-clippy/master/index.html#/single_range_in_vec_init The page says "this is almost always incorrect", but it seems clear that this is quite intentional in our case here. So I silenced the warning by adding an #[allow annotation.

@jnross
Copy link
Contributor Author

jnross commented Sep 3, 2023

I updated this PR with an improved fix for gha-ubuntu-cross and included the fixes from #467 so checks will pass.

Copy link
Member

@jessebraham jessebraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for getting that fixed!

@jessebraham jessebraham merged commit 129439a into esp-rs:main Sep 12, 2023
@jnross jnross deleted the joe/fix-ci branch September 21, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants