Avoid updating clap to newer minor versions #467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clap_complete4.4.0 raised MSRV to 1.70, breaking CI due to espflash only specifying 1.65.As per clap-rs/clap#5087 the clap project treats MSRV breaks as minor changes. While this is also what cargo suggests, it's simpler to lock clap to patch releases than to keep bumping MSRV every 6 weeks.
I've also resolved two clippy lint issues, at least one of them affecting CI.
Hopefully, along with #465 this will fix the current CI woes.