Skip to content

Conversation

9names
Copy link
Contributor

@9names 9names commented Jul 30, 2022

Update a few more dependencies to get things building

@9names
Copy link
Contributor Author

9names commented Jul 30, 2022

A bunch of small things need updating as the API around some functions have changed

@Mirabellensaft
Copy link
Contributor

@9names This is marked as draft, what is missing for it to be ready for review/merge?

@9names
Copy link
Contributor Author

9names commented Aug 11, 2022

I was in the middle of testing if mqtt working, and got sidetracked by other projects. it looks like I didn't push those changes so it's probably ok to mark as ready for review.

@9names 9names marked this pull request as ready for review August 11, 2022 20:53
@BriocheBerlin
Copy link
Contributor

@9names Would you mind adding those changes mentioned? Currently for me neither mqtt nor i2c-sensor-reading are building.

@9names
Copy link
Contributor Author

9names commented Aug 15, 2022

But... CI is green? Are they not being built, or have dependencies moved underneath us?

I should close this PR, as it against amanjeev's branch but both have been rebased against main merging it would be problematic.

@9names
Copy link
Contributor Author

9names commented Aug 15, 2022

I've pushed the WIP changes into https://github.com/9names/espressif-trainings/tree/mqtt-rebase. My recollection is that it mqtt compiles but the impl should not be considered correct (I did not get it communicating with my mqtt server)

@BriocheBerlin
Copy link
Contributor

Closed through #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants