Skip to content

Clean branch flashing and wifi connection #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 2, 2022
Merged

Clean branch flashing and wifi connection #99

merged 13 commits into from
Sep 2, 2022

Conversation

Dajamante
Copy link
Contributor

Minor changes:

  • removed new_with_conn
  • new_with_call back could be replace by new
  • logging other output from MQTT (minor!)

9names and others added 13 commits September 2, 2022 13:55
@9names @BriocheBerlin
Update esp and riscv dependencies
159af1d
@9names @BriocheBerlin
Update http-client example with new esp API
1c45875
@9names @BriocheBerlin
Update http server example
521ba18
@9names @BriocheBerlin
wip mqtt solution
f6b3f34
@amanjeev @BriocheBerlin
fix(bsc): wifi connection; need to wait until the status is right
04e638c
@amanjeev @BriocheBerlin
fix(wifi waiting): instead of a custom loop, use wifi waiting provided
9025595 
previous commit was using a custom loop but this PR comment[1] points to
a better way `wait_status_with_timeout` method. this method was dependent
upon using the latest versions of the dependencies, esp. esp-idf-svc.
Without these updates to respective crates, Cargo was unhappy with conflicts
of base crates like embeddad-hal.

[1] #84 (comment)
@BriocheBerlin
Update shared-bus version to 0.2.4.
f290330
@BriocheBerlin
Fix http-client solution1 and book.
53d0b11
@BriocheBerlin
Fix mqtt solution1.
d9f45a8
@BriocheBerlin
Add more troubleshooting to http_server.
f89614e
@Dajamante @BriocheBerlin
Not working yet, typical output:
f1561fd 
I (5490) mqtt: Entry point :: BeforeConnect
I (5490) mqtt: Some stuff: BeforeConnect
I (6500) mqtt: Entry point :: Connected(false)
I (6500) mqtt: True or false false
I (7500) mqtt: Entry point :: Published(62839)
I (7500) mqtt: MQTT Message : Published(62839)
I (8500) mqtt: Entry point :: Published(18102)
@Dajamante @BriocheBerlin
working again
1c4168f
@Dajamante @BriocheBerlin
working and logs other info from mqtt
6b10f4e
@BriocheBerlin BriocheBerlin force-pushed the clean_branch_flashing_and_wifi_connection branch from 62fa3b5 to 6b10f4e Compare September 2, 2022 11:55
BriocheBerlin
BriocheBerlin approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@BriocheBerlin BriocheBerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Solution1 and solution2 will be fixed in an additional pr.

@BriocheBerlin
Copy link
Contributor

This closes #85 and #91

@BriocheBerlin BriocheBerlin merged commit 15627c5 into main Sep 2, 2022
This was referenced Sep 2, 2022
Closed
Closed
This was referenced Sep 6, 2022
Closed
Closed
Closed
@Dajamante Dajamante deleted the clean_branch_flashing_and_wifi_connection branch September 8, 2022 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amanjeev amanjeev Awaiting requested review from amanjeev

1 more reviewer

@BriocheBerlin BriocheBerlin BriocheBerlin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Dajamante @BriocheBerlin @9names @amanjeev