Master #4002
Closed
Master #4002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds additional logging to the database migration codepath. This is helpful for understanding what is happening in the code, to understand how much of the migration has already happened. It may also help catch programmer/configuration errors, although we should have testing to catch that and not rely on the programmer watching the logs to catch issues.
Adds checks for the MigrationSystemDictator steps.
feat(ctb): add MigrationSystemDictator checks
TestConfirmationDepth was consistently failing on the HTTP versions of the op-e2e test. It was failing at the last line that checked the verifier head block timestamp against the L1 head timestamp. I have changed it to compare the verifier L1 Origin number against the L1 head number.
Running them sequentially actually turns out to be faster. In addition it turns out to be very hard to split the tests properly. `go list ./...` which was the previous approach splits them by package, but we need to split them by test name. Using `circleci tests glob "**/*.go"` did not work either becaue it was combining files from different packages.
* Start contract changes for two step withdrawals v2 * Fix maurelian's nits * Refactor Kelvin's SDK changes; SDK/integration test time * Merge w/ `develop` * Add tests for changed output proposal *after* proving the withdrawal hash Whoops * Gas snapshot / comments * Regenerate bindings; Fix E2E Withdrawal test; Add extra indexed params to `WithdrawalProven` * Start fixing indexer integration tests * Fix conflicts; Start updating mark's new `op-e2e` withdrawal action tests * Remove proposal timestamp >= withdrawal timestamp check * Fix mark's `op-e2e` test + add docs to `proveMessage` in SDK * Update changeset * Lint contracts * Merge with `develop` * Re-order mapping declarations so that `finalizedWithdrawals` retains its old storage slot * Merge with `develop` * Start updating devnet tests * Fix devnet tests * Update ERC20 binding * Clean up SDK * Merge with `develop` * Remove `integration-tests-bedrock` package * Add check for equality between locally computed withdrawal hash vs. on-chain withdrawal hash * Add Kelvin's check + complimentary test Update bindings * Fix finalization period in `TestCrossLayerUser`
op-chain-ops: add logging to db migration
🦋 Changeset detectedLatest commit: 8f7a40c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
2-reviewers
A-pkg-contracts-bedrock
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of the features you're adding in this pull request.
Tests
Please describe any tests you've added. If you've added no tests, or left important behavior untested, please explain why not.
Additional context
Add any other context about the problem you're solving.
Metadata