Add __mod__ to FQ and FQP for type hinting #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwwhww
force-pushed
the
for_type_hinting_2
branch
from
13749c7 to
2e730ae
Compare
|
I assume you want a patch release for this asap? |
pipermerriam
approved these changes
Dec 12, 2018
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
For type hinting, it requires
__mod__to return the correctHow was it fixed?
Add
__mod__forFQPfor type hinting.Cute Animal Picture
Also, on Py-EVM side, hwwhww/py-evm@a326a0e would work with this PR.