Skip to content

Add __mod__ to FQ and FQP for type hinting #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Add __mod__ to FQ and FQP for type hinting #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions py_ecc/optimized_bn128/optimized_field_elements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ def __sub__(self, other: IntOrFQ) -> "FQ":
on = other.n if isinstance(other, FQ) else other
return FQ((self.n - on) % field_modulus)

def __mod__(self, other: Union[int, "FQ"]) -> "FQ":
return self.__mod__(other)

def __div__(self, other: IntOrFQ) -> "FQ":
on = other.n if isinstance(other, FQ) else other
assert isinstance(on, int)
Expand Down Expand Up @@ -171,6 +174,9 @@ def __sub__(self, other: "FQP") -> "FQP":
in zip(self.coeffs, other.coeffs)
])

def __mod__(self, other: Union[int, "FQP"]) -> "FQP":
return self.__mod__(other)

def __mul__(self, other: Union[int, "FQP"]) -> "FQP":
if isinstance(other, int):
return type(self)([int(c) * other % field_modulus for c in self.coeffs])
Expand Down