Skip to content

Conversation

@F3n67u
Copy link

@F3n67u F3n67u commented Apr 1, 2022

Summary

bump jest to v27

Changelog

[Internal] [Changed] - upgrade jest to v27

Test Plan

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 1, 2022
@pull-bot
Copy link

pull-bot commented Apr 1, 2022

Messages
📖

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 8d01690

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 8adedfe
Branch: main

@SimenB
Copy link
Contributor

SimenB commented Apr 25, 2022

28 is out, fwiw.

(@rickhanlonii any idea who to ping to move this forward? Perhaps @robhogan as he was very helpful with #33576?)

That said, I know in the past a jest upgrade has been an internal thing hard to contribute from the outside

"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-flowtype": "^7.0.0",
"eslint-plugin-jest": "^25.2.4",
"eslint-plugin-jest": "^26.1.3",
Copy link
Contributor

@SimenB SimenB Apr 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint plugin should be separate from jest itself, they are not connected by major version

@kelset
Copy link
Contributor

kelset commented Apr 26, 2022

as far as I know, Jest won't be upgraded to v27 for this repo because it needs to match what's used internally and they are still on 26.x

@cortinico
Copy link
Contributor

as far as I know, Jest won't be upgraded to v27 for this repo because it needs to match what's used internally and they are still on 26.x

That's correct. The bump will have to be done as we migrate the whole codebase to the new version of Jest.

@cortinico
Copy link
Contributor

as far as I know, Jest won't be upgraded to v27 for this repo because it needs to match what's used internally and they are still on 26.x

That's correct. The bump will have to be done as we migrate the whole codebase to the new version of Jest.

I'm closing this for now. This will have to be driven from internally. Thanks for sending it over though @F3n67u 🙏

@cortinico cortinico closed this May 9, 2022
@F3n67u F3n67u deleted the bump-jest branch May 10, 2022 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants