pass host context to finalizeInitialChildren #11970
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yenshih
pushed a commit
to yenshih/react
that referenced
this pull request
Jan 6, 2018
* pass host context to finalizeInitialChildren * don't retrieve context an extra time
ManasJayanth
pushed a commit
to ManasJayanth/react
that referenced
this pull request
Jan 12, 2018
* pass host context to finalizeInitialChildren * don't retrieve context an extra time
This was referenced Mar 30, 2018
This was referenced Apr 1, 2018
This was referenced Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m sorry i didn’t include a test, i wasn’t sure where or how to confirm this in one. I’m happy to add it if someone has a sense on where to stick it.
for reference for the change: jquense/react-dom-lite#14 (comment)