Skip to content

pass host context to finalizeInitialChildren #11970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 5, 2018
Merged

pass host context to finalizeInitialChildren #11970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c210e75
pass host context to finalizeInitialChildren
jquense Jan 5, 2018
a0f39b7
don't retrieve context an extra time
jquense Jan 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react-reconciler/src/ReactFiberCompleteWork.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
oldProps: P,
newProps: P,
rootContainerInstance: C,
currentHostContext: CX,
) {
// TODO: Type this specific to this type of component.
workInProgress.updateQueue = (updatePayload: any);
Expand Down Expand Up @@ -288,6 +289,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
oldProps: P,
newProps: P,
rootContainerInstance: C,
currentHostContext: CX,
) {
// If there are no effects associated with this node, then none of our children had any updates.
// This guarantees that we can reuse all of them.
Expand Down Expand Up @@ -315,6 +317,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
type,
newProps,
rootContainerInstance,
currentHostContext,
)
) {
markUpdate(workInProgress);
Expand Down Expand Up @@ -369,6 +372,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
oldProps: P,
newProps: P,
rootContainerInstance: C,
currentHostContext: CX,
) {
// Noop
};
Expand Down Expand Up @@ -450,6 +454,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
oldProps,
newProps,
rootContainerInstance,
currentHostContext,
);

if (current.ref !== workInProgress.ref) {
Expand Down Expand Up @@ -506,6 +511,7 @@ export default function<T, P, I, TI, HI, PI, C, CC, CX, PL>(
type,
newProps,
rootContainerInstance,
currentHostContext,
)
) {
markUpdate(workInProgress);
Expand Down
1 change: 1 addition & 0 deletions packages/react-reconciler/src/ReactFiberReconciler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export type HostConfig<T, P, I, TI, HI, PI, C, CC, CX, PL> = {
type: T,
props: P,
rootContainerInstance: C,
hostContext: CX,
): boolean,

prepareUpdate(
Expand Down