- 
                Notifications
    You must be signed in to change notification settings 
- Fork 49.7k
[Flight] Color and badge non-primary environments #31738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| The latest updates on your projects. Learn more about Vercel for Git ↗︎ 
 | 
ff997f3    to
    492ac59      
    Compare
  
    492ac59    to
    22ad1ec      
    Compare
  
    22ad1ec    to
    4e9c5f3      
    Compare
  
    4e9c5f3    to
    0aa0aee      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider as an alternative to use the env as a prefix instead of a suffix? This would align it with replayed logs, and avoid two successive brackets, e.g. [Cache] ServerComponent [deduped] vs. ServerComponent [Cache] [deduped].
0aa0aee    to
    8e7e6da      
    Compare
  
    8e7e6da    to
    09ea57d      
    Compare
  
    | This is aligning with the React DevTools tree view where it's after. | 
…act into issue-31578-setter-arity-gcc * 'issue-31578-setter-arity-gcc' of github.com:/davesnx/react: [flags] Clean up scheduler flags (facebook#31814) Enable debugRenderPhaseSideEffectsForStrictMode in test renderers (facebook#31761) Enable disableDefaultPropsExceptForClasses (facebook#31804) Turn on useModernStrictMode in test renderers (facebook#31769) [compiler][ez] Add shape for global Object.keys (facebook#31583) [compiler] Context variables as dependencies (facebook#31582) [compiler] Add fire to known React APIs (facebook#31795) [compiler] Add option for firing effect functions (facebook#31794) [compiler][be] Logger based debug printing in test runner (facebook#31809) [compiler][ez] Clean up duplicate code in propagateScopeDeps (facebook#31581) [compiler] Repro for aliased captures within inner function expressions (facebook#31770) [compiler][be] Playground now compiles entire program (facebook#31774) [Flight] Color and badge non-primary environments (facebook#31738) [Flight] Emit Deduped Server Components Marker (facebook#31737) [Flight] Sort Server Components Track Group ahead of Client Scheduler/Components Tracks (facebook#31736) Clean up context access profiling experiment (facebook#31806) [Flight] Stack Parallel Components in Separate Tracks (facebook#31735) Flag for requestPaint (facebook#31805)
Stacked on #31737.
When mixing environments (like "use cache" or third party RSC) it's useful to color and badge those components differently to differentiate.
I'm not putting them in separate tracks because when they do actually execute, like cache misses or third party RSCs, they behave like they're part of the same tree.