Skip to content

Clean up enableLazyContextPropagation #31810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2024
Merged

Clean up enableLazyContextPropagation #31810

merged 1 commit into from
Dec 17, 2024
+53 −331

Conversation

@jackpope
Copy link
Contributor

@jackpope jackpope commented Dec 16, 2024

This flag has shipped everywhere, let's clean it up.

@vercel
Copy link

vercel bot commented Dec 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 7:36pm

@facebook-github-bot facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Dec 16, 2024
@react-sizebot
Copy link

react-sizebot commented Dec 16, 2024

Comparing: 54e86bd...aecfbde

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 510.76 kB 510.66 kB = 91.36 kB 91.30 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 515.55 kB 515.44 kB = 92.17 kB 92.15 kB
facebook-www/ReactDOM-prod.classic.js = 592.44 kB 592.36 kB = 104.43 kB 104.36 kB
facebook-www/ReactDOM-prod.modern.js = 582.70 kB 582.63 kB = 102.88 kB 102.80 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 4780da8

@jackpope jackpope merged commit 34ee391 into facebook:main Dec 17, 2024
187 checks passed
@jackpope jackpope deleted the enable-lazy-context-prop-flag branch December 17, 2024 16:56
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@jackpope
Clean up enableLazyContextPropagation (#31810)
613f8c3 
This flag has shipped everywhere, let's clean it up.

DiffTrain build for [34ee391](34ee391)
github-actions bot pushed a commit that referenced this pull request Dec 17, 2024
@jackpope
Clean up enableLazyContextPropagation (#31810)
5963da6 
This flag has shipped everywhere, let's clean it up.

DiffTrain build for [34ee391](34ee391)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 17, 2024
@pull
Clean up enableLazyContextPropagation (facebook#31810)
c244ce9 
This flag has shipped everywhere, let's clean it up.

DiffTrain build for [34ee391](facebook@34ee391)
github-actions bot pushed a commit to code/lib-react that referenced this pull request Dec 17, 2024
@pull
Clean up enableLazyContextPropagation (facebook#31810)
01814dd 
This flag has shipped everywhere, let's clean it up.

DiffTrain build for [34ee391](facebook@34ee391)
This was referenced Dec 18, 2024
Closed
Closed
Closed
Closed
Closed
Merged
@captbaritone captbaritone mentioned this pull request Apr 11, 2025
Closed
@dkempner dkempner mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kassens kassens kassens approved these changes

Assignees

No one assigned

Labels

CLA Signed React Core Team Opened by a member of the React Core Team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jackpope @react-sizebot @kassens @facebook-github-bot