Make Firecracker's instance ID configurable #442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The corresponding change I made for Go SDK is not required 🤦 |
Firecracker's instance ID is appeared in Firecracker's log file. Setting the ID makes the log easily trackable from clients. Signed-off-by: Kazuyoshi Kato <[email protected]>
xibz
approved these changes
Jul 30, 2020
It doesn't hurt to make it configurable in the config though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
Firecracker's instance ID is appeared in Firecracker's log
file. Setting the ID makes the log easily trackable from clients.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.