Pin dependencies #449
Pin dependencies #449
Conversation
Signed-off-by: Mathis Joffre <[email protected]>
Kern--
force-pushed
the
main
branch
2 times, most recently
from
d909be7 to
01d1271
Compare
examples/cmd/snapshotting/Makefile
Outdated
| GO111MODULE=on GOBIN=$(GOBIN) go get $(1) && \ | ||
| GO111MODULE=on GOBIN=$(GOBIN) go install $(1) |
There was a problem hiding this comment.
Do we need to do an || true here since one will fail or @ the call?
There was a problem hiding this comment.
No, it seems like what we actually need is this (ignoring setting env vars for clarity):
go 1.14/1.15:
go get $PACKAGE@$VERSION
go install $PACKAGE
go 1.16+
go install $PACKAGE@$VERSION
I've been banging my head against a wall trying to figure out a reasonable way to do this either in the Makefile or in portable shell scripting, but maybe it's worth just having the 10 or so gross if/else make rules.
Kern--
force-pushed
the
main
branch
2 times, most recently
from
59dbe87 to
f274f81
Compare
|
Looks like the buildkite pipeline installs a plugin as well. We can probably replace that with an explicit make target call to install or let make dependencies handle it. |
|
The load snapshot integration tests will intermittently fail which #418 is trying to address. That is outside the scope of this change which is why I reran for the green. |
This change pins our binary dependencies (CNI and project checks) in a way that works with go versions >=1.14 Signed-off-by: Kern Walster <[email protected]>
|
@Joffref This will take the place of your PR. Can you please take a look? |
5 participants
Signed-off-by: Kern Walster [email protected]
Issue #, if available:
Closes #446
Description of changes:
This pins our binary dependencies (CNI + project checks) in a way that is compatible with go versions >= 1.14.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.