Do not overwrite handlers in LoadSnapshot #630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| func modifyHandlersForLoadSnapshot(l HandlerList) HandlerList { | ||
| for _, h := range loadSnapshotRemoveHandlerList { | ||
| l = l.Remove(h.Name) |
Contributor
There was a problem hiding this comment.
Does Remove handle the case when h.Name is not present in the Handler list?
Contributor
Author
There was a problem hiding this comment.
Seems it should return the same HandlerList: https://github.com/firecracker-microvm/firecracker-go-sdk/blob/main/handlers.go#L448
| LoadSnapshotHandler, | ||
| AddVsocksHandler, | ||
| ) | ||
| var loadSnapshotRemoveHandlerList = []Handler{ |
Contributor
There was a problem hiding this comment.
Can you please add a comment here for future reference on why we need to have a filter list?
sondavidb
force-pushed
the
fix-snapshot-handler-override
branch
from
0a2e6de to
d0d94d9
Compare
As LoadSnapshot requires only a subset of the default handlers, it was implemented by assigning the FcInit handlers to a smaller list of handlers. However, this meant that it would overwrite the FcInit handlers given by the jailer. This PR fixes this behavior by just removing the unnecessary handlers, instead of overwriting them entirely. Signed-off-by: David Son <[email protected]>
sondavidb
force-pushed
the
fix-snapshot-handler-override
branch
from
d0d94d9 to
f599c51
Compare
swagatbora90
approved these changes
Feb 25, 2025
chews93319
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #627
Description of changes:
As LoadSnapshot requires only a subset of the default handlers, it was implemented by assigning the FcInit handlers to a smaller list of handlers. However, this meant that it would overwrite the FcInit handlers given by the jailer. This PR fixes this behavior by just removing the unnecessary handlers, instead of overwriting them entirely.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.