Skip to content

Conversation

@austinvazquez
Copy link
Contributor

Signed-off-by: Austin Vazquez [email protected]

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@austinvazquez
Copy link
Contributor Author

So my debugging revealed that the BuildKite CI failures are likely caused by this PR: #630

Previously we would override the configuration validation handler list when loading snapshots and have broken that behavior. I don't think we need to have the full configuration validation. e.g. the current error is due to not providing a kernel image path which is a valid use case for loading snapshots.

@austinvazquez austinvazquez changed the title Debug BuildKite CI failures for snapshotting tests Fix BuildKite CI for kernel image path errors when loading snapshots Mar 13, 2025
@austinvazquez
Copy link
Contributor Author

Chatted to @sondavidb offline. It seems the fix was for users that specify their own handlers so overwriting validation here might not produce the desired effect. e.g. users may have validation for their handlers. So alternatively suggesting to remove the configuration validation when loading a snapshot.

@austinvazquez austinvazquez marked this pull request as ready for review March 13, 2025 19:54
@austinvazquez austinvazquez requested a review from a team as a code owner March 13, 2025 19:54
@austinvazquez austinvazquez merged commit b21aef6 into firecracker-microvm:main Mar 13, 2025
3 checks passed
@austinvazquez austinvazquez deleted the fix-buildkite-ci branch March 13, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants