Continue Reading on Bad Messages #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests passed, the CI failure is RuboCop issues that were not part of this PRs changes. |
|
Thanks @jtwile2 I will certainly take a look at this over the next few days ... The reevoocop stuff just seems to be related to complexity, I figure we could use a little refactoring at this point so I will take a look at that before merging this in... |
|
Sounds good, I don't have any plans to backport this to the 0.0.x branch, but if you need that, I can take a look. |
chancez
pushed a commit
to chancez/fluent-plugin-systemd
that referenced
this pull request
Nov 21, 2017
Backport of fluent-plugins-nursery#41 to 0.0.x branch
chancez
pushed a commit
to chancez/fluent-plugin-systemd
that referenced
this pull request
Nov 21, 2017
Backport of fluent-plugins-nursery#41 to 0.0.x branch
chancez
pushed a commit
to chancez/fluent-plugin-systemd
that referenced
this pull request
Nov 21, 2017
Backport of fluent-plugins-nursery#41 to 0.0.x branch
chancez
pushed a commit
to chancez/fluent-plugin-systemd
that referenced
this pull request
Nov 21, 2017
Backport of fluent-plugins-nursery#41 to 0.0.x branch
errm
added a commit
that referenced
this pull request
May 3, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue reading on corrupted messages in the journal. Addresses Issue #16.