Gracefully handle corrupted journal log entries #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of fluent-plugins-nursery#41 to 0.0.x branch
|
Er, hello? This Pull Request is too damn old! Merge or close this, sucka. |
Fluentd 0.12.x and msgpack expect ruby < 2.4.
|
Sorry, hadn't had a chance to look into the issue too much; I hadn't seen it before. I believe it's a ruby version thing and travis is using the latest version of ruby at least on the 0.8 based branches. We'll see if my latest commit fixes that. |
|
Tests pass; rubocop fails but its for unrelated things since nothing has changed relating to it's complaints. I'm guessing it's a newer rubocop or something that fails with the older 0.8 branch. I don't really know much about rubocop so I'm not 100% sure what the solution to that is besides just fixing these things? |
|
Looks good to me... thanks for the PR |
chancez
force-pushed
the
0.8_handle_corrupted_logs
branch
from
213f86c to
a496468
Compare
chancez
force-pushed
the
0.8_handle_corrupted_logs
branch
from
a496468 to
9eb8473
Compare
|
i got everything to pass :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a back port of #41 to the 0.0.x branch. If you don't want to accept this; I understand, but I saw some others who requested this so I figured I would open a PR.