Skip to content

Flutter for Android/iOS/Xamarin page tweaks #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 25, 2018
Merged

Flutter for Android/iOS/Xamarin page tweaks #1116

merged 3 commits into from
Jul 25, 2018

Conversation

@chalin
Copy link
Contributor

@chalin chalin commented Jul 24, 2018 •
edited
Loading

  • Mainly page markdown cleanup (switched to using markdown numbered-list syntax and code fences). There is no change in appearance for the affected pages.
  • Almost no content change except for one small adjustment in web-analogs (I'll point it out using an inlined comment).
  • Actually, I ended up having to convert two files from DOS line endings to unix.

cc @Sfshaza

@googlebot googlebot added the cla: yes Contributor has signed the Contributor License Agreement label Jul 24, 2018
chalin
chalin commented Jul 24, 2018
View reviewed changes
flutter-for-xamarin-forms.md

Your Android and iOS knowledge and skill set are valuable when building with
Flutter, because Flutter relies on the native operating system configurations, similar to
how you would configure your native Xamarin.Forms projects. The Flutter Frameworks is
Copy link
Contributor Author

@chalin chalin Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My VS Code removes trailing whitespace from lines, which is what accounts for most of the changes in this file.

chalin
chalin commented Jul 24, 2018
View reviewed changes
web-analogs.md
for all HTML elements is set to
[`border-box`](https://css-tricks.com/box-sizing/),
for consistency with the Flutter model.
{% prettify css %}<!DOCTYPE html>
Copy link
Contributor Author

@chalin chalin Jul 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code excerpt used to have <!DOCTYPE html> in a CSS code block. I moved <!DOCTYPE html> into the sentence instead. Is that ok @Sfshaza?

Copy link
Contributor

@Sfshaza Sfshaza Jul 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@chalin
Copy link
Contributor Author

chalin commented Jul 24, 2018

If you prefer, you can examine this PR while ignoring whitespace changes: https://github.com/flutter/website/pull/1116/files?w=1. That'll help you focus on the real changes.

@chalin chalin force-pushed the chalin-minor-page-adjustments-0724 branch 4 times, most recently from f192a11 to 700edbc Compare July 24, 2018 23:23
@chalin
Copy link
Contributor Author

chalin commented Jul 24, 2018 •
edited
Loading

@Sfshaza - Test are passing. The build is now failing but only because of

- ./_site/showcase/index.html
  *  External link https://adwords.google.com/home/resources/adwords-app.html failed: 404 No error

See #1119.

It is tricky to have the pass/fail status of a build depend on external links (it is usually be to treat them as warnings). The travis.sh script should probably be broken down into parts with some parts being allowed to fail.

@Sfshaza
Copy link
Contributor

Sfshaza commented Jul 25, 2018 •
edited
Loading

I agree about the challenge of external links. Flutter has always done it that way, but I welcome turning those from errors to warnings. LGTM

@chalin chalin mentioned this pull request Jul 25, 2018
Closed
chalin added 3 commits July 25, 2018 05:25
@chalin chalin force-pushed the chalin-minor-page-adjustments-0724 branch from 700edbc to f373038 Compare July 25, 2018 09:25
@chalin
Copy link
Contributor Author

chalin commented Jul 25, 2018

I agree about the challenge of external links. Flutter has always done it that way, but I welcome turning those from errors to warnings.

I've opened flutter/flutter#19752 to track that.

@chalin
Copy link
Contributor Author

chalin commented Jul 25, 2018

Finally, Travis is green!

@Sfshaza
Copy link
Contributor

Sfshaza commented Jul 25, 2018

LGTM

@Sfshaza Sfshaza merged commit d1b1f9d into flutter:master Jul 25, 2018
@chalin chalin deleted the chalin-minor-page-adjustments-0724 branch July 25, 2018 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Sfshaza Sfshaza Sfshaza left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Contributor has signed the Contributor License Agreement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chalin @Sfshaza @googlebot