Fix alert not work in webview #522
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 18, 2019
|
thank you for PR, looks good so far, but I need to check it. btw. android alert works |
|
Hi, is this here flutter/plugins#2012 now obsolete? |
|
I have create similar PR for both, because it seems they both used as webview in flutter. |
|
ah sorry I missed that its two different widgets. |
|
Hi, I made up the enhanced version of this pull request. #655. |
|
I am merging this first because it's fix to current solution. Will review the other one next (and sooner, I promise) |
charafau
pushed a commit
that referenced
this pull request
Apr 7, 2020
* fix alert() not working in iOS webview * inlcude alert() in example project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have debug with #376
For iOS part
Found it's related to iOS native part iOS WKWebView not showing javascript alert() dialog
Good example of implement code are at gist.
NOTE: This fix not test android part of alert().