Implement onJSAlert, onJSConfirm, onJSPrompt interface #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Never set minSdk and targetSdk in manifest.
Taking safe areas into account for bottom bars
Allow local files on iOs > 9.0
Added reloading (Android)
from dart2, getCookies throws type conversion error. Refer to https://stackoverflow.com/questions/49824167/breaking-exception-internallinkedhashmapdynamic-dynamic-is-not-a-subtype-o
Add 'show', 'hide', and 'reloadUrl' functions
…#600) * added callbacks to canGoForward and canGoBack for android * added flutter tests added ios implementation * updated readme
* Fixed ios compilation, added clear cache for ios * added cleaning cache for android * updated readme
* add ignoreSSLErrors parameter - just Android * iOS implementation to allow ignore SSL Errors * add documentation for ignoreSSLErrorsFlag * remove log messages used for ignorSSLErrors debug
* remove local properties * added jetifier for example project
Fixed some typos. Good writeup.
j796160836
force-pushed
the
develop/alert_interface
branch
from
6780259 to
3973221
Compare
j796160836
requested review from
charafau,
lejard-h and
slightfoot
and removed request for
charafau and
lejard-h
|
Thank you for PR and sorry for long review time, I am quite busy these days. |
|
@j796160836 conflicted |
added 5 commits
January 17, 2022 09:36
# Conflicts: # .github/workflows/android_ut.yml # .github/workflows/flutter_ut.yml # CHANGELOG.md # README.md # example/lib/main.dart # ios/Classes/FlutterWebviewPlugin.m # lib/src/base.dart # lib/src/javascript_channel.dart # lib/src/webview_scaffold.dart # pubspec.yaml # test/flutter_webview_plugin_test.dart
j796160836
force-pushed
the
develop/alert_interface
branch
from
06f8d9f to
fc996e2
Compare
|
Any updates on this feature? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #376, enhanced Pull request by: #522.
Instead of implement native code, I advocate it handling that flutter side.
I extract both iOS and Android native callback into three functions.
Native callback
Flutter callback
Also, I filled up the example.