Skip to content

Print the matched text for unknown spdx #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Print the matched text for unknown spdx #19

wants to merge 4 commits into from

Conversation

soimkim
Copy link
Contributor

@soimkim soimkim commented Jun 24, 2021

Description

Print the matched text for unknown spdx license

Type of change

Please insert 'x' one of the type of change.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added the minor [PR version] Minor version up (ex, vA.B.C : B version up) label Jun 24, 2021
@soimkim soimkim requested review from dd-jy and bjk7119 June 24, 2021 07:21
@dd-jy
Copy link
Contributor

dd-jy commented Jun 24, 2021

Is the prefix 'licenseref-' in matched_text always included?
If not, how about looking up the text behind the 'SPDX-License-Identifier: '?
If always included, just ignore my comment.

@soimkim
Copy link
Contributor Author

soimkim commented Jun 24, 2021

@dd-jy ,
I was worried about that too.
What you said is a better idea.
I'll update it as you say!

@soimkim
Copy link
Contributor Author

soimkim commented Jun 25, 2021

This PR is replaced by #20.

@soimkim soimkim closed this Jun 25, 2021
@soimkim soimkim deleted the develop branch June 25, 2021 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dd-jy dd-jy Awaiting requested review from dd-jy

@bjk7119 bjk7119 Awaiting requested review from bjk7119

Assignees
No one assigned
Labels
minor [PR version] Minor version up (ex, vA.B.C : B version up)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soimkim @dd-jy