Skip to content

Print the matched text for unknown spdx #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2021
Merged

Print the matched text for unknown spdx #20

merged 1 commit into from
Jun 25, 2021

Conversation

soimkim
Copy link
Contributor

@soimkim soimkim commented Jun 25, 2021

Description

Print the matched text for unknown spdx

Type of change

Please insert 'x' one of the type of change.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Refactoring, Maintenance
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@soimkim soimkim added enhancement [PR/Issue] New feature or request minor [PR version] Minor version up (ex, vA.B.C : B version up) labels Jun 25, 2021
@soimkim soimkim requested review from dd-jy, k2heart and bjk7119 June 25, 2021 00:22
@soimkim soimkim mentioned this pull request Jun 25, 2021
Closed
5 tasks
@soimkim
Copy link
Contributor Author

soimkim commented Jun 25, 2021

If you look at the result extracted from the tox execution result to the test_unknown_spdx.txt file, you can check the License result for Unknown SPDX.

License text in test_unknown_spdx.txt file

# SPDX-License-Identifier: LicenseRef-MIT-like

License result for test_unknown_spdx.txt file.

licenseref-mit-like

@bjk7119
Copy link
Contributor

bjk7119 commented Jun 25, 2021

LGTM :)

@soimkim soimkim merged commit 9b21384 into main Jun 25, 2021
@soimkim soimkim deleted the temp branch June 25, 2021 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dd-jy dd-jy Awaiting requested review from dd-jy

@k2heart k2heart Awaiting requested review from k2heart

@bjk7119 bjk7119 Awaiting requested review from bjk7119

Assignees
No one assigned
Labels
enhancement [PR/Issue] New feature or request minor [PR version] Minor version up (ex, vA.B.C : B version up)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@soimkim @bjk7119