Skip to content

Conversation

@leandro-lucarella-frequenz
Copy link
Contributor

@leandro-lucarella-frequenz leandro-lucarella-frequenz commented Dec 2, 2022

The fixture didn't always work because in cases where the actor kept running past the pytest session end, and failed then, the original restart limit was reestablished, running into the infinite loop again.

Maybe related to #41.

@leandro-lucarella-frequenz leandro-lucarella-frequenz requested a review from a team as a code owner December 2, 2022 14:43
@leandro-lucarella-frequenz leandro-lucarella-frequenz added this to the v0.13.0 milestone Dec 2, 2022
@leandro-lucarella-frequenz leandro-lucarella-frequenz added the type:bug Something isn't working label Dec 2, 2022
@github-actions github-actions bot added the part:tests Affects the unit, integration and performance (benchmarks) tests label Dec 2, 2022
@leandro-lucarella-frequenz
Copy link
Contributor Author

leandro-lucarella-frequenz commented Dec 2, 2022

Hopefully it fixes #41, even when I wrote that issue I don't fully understand what is it really about, as the error that is shown in the issue description doesn't seem to match very well the title...

It talks about some test deriving from IsolatedAsyncioTestCase but then the link doesn't point to a test deriving from it, so I think something got messed up when I wrote it.

In any case, I bumped with an issue with this fixture, which took me a long time to figure out because I kept running into the infinite loop, so this at least fixes something.

The fixture didn't always work because in cases where the actor kept
running past the pytest session end, and failed then, the original
restart limit was reestablished, running into the infinite loop again.

Fixes frequenz-floss#41.

Signed-off-by: Leandro Lucarella <[email protected]>
@leandro-lucarella-frequenz
Copy link
Contributor Author

BTW @ela-kotulska-frequenz it seems like you wrote #41 originally. Re-reading it and looking at Jakub's comment, it doesn't look like this is fixing it. At least Jakub said one needs to use IsolatedAsyncioTestCase for the auto-fixture to be used.

If you could check if the error described in #41 still happens before and after applying this fix it might be useful to know if we can close #41 or not.

@leandro-lucarella-frequenz leandro-lucarella-frequenz merged commit 458047f into frequenz-floss:v0.x.x Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

part:tests Affects the unit, integration and performance (benchmarks) tests type:bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

3 participants