Skip to content

Fix the disable_actor_auto_restart fixture #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2022
Merged

Fix the disable_actor_auto_restart fixture #97

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,12 @@
def disable_actor_auto_restart(): # type: ignore
"""Disable auto-restart of actors while running tests.

Since this is auto-use, the yield part (and restore of the variable) is not
strictly needed, but we leave it as an example.
At some point we had a version that would set the limit back to the
original value but it doesn't work because some actors will keep running
even after the end of the session and fail after the original value was
reestablished, getting into an infinite loop again.

Note: Test class must derive after unittest.IsolatedAsyncioTestCase.
Otherwise this fixture won't run.
"""
original_restart_limit = _decorator.BaseActor.restart_limit
_decorator.BaseActor.restart_limit = 0
yield
_decorator.BaseActor.restart_limit = original_restart_limit