-
Notifications
You must be signed in to change notification settings - Fork 49
Improve Asset Switcher GUI #376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Asset Switcher GUI #376
Conversation
…l subsets from subset's dropdown
|
Looking sweet. Will give this a roll some day soon to test it out and look at the code. Great work! |
|
@iLLiCiTiT I'll be looking into this one (finally!) today and test the ins- and outs. Can you confirm that this is still in the working state as you are using it? Or do you internally have brought other updates/fixes to this interface? |
|
I think this is final version for this issue(if you won't find bugs). Only other update is LOD support, that requires new issue and probably not my implementation. It is very messy dirty code which works, but any future edit will be hell... |
|
Had a quick glance at this PR and there is an issue with it where it disallows a certain switching where previously it would allow it. Specifically, the idea about the switch UI is that you can select any number of different types of content and switch all to a different shot - even where some might not be able to do the same switch. So say I load: And shot two only has Then the idea is that the user could still select all things in the Scene Inventory, click Switch Asset UI and switch to shot 2 - with only pointcacheBackground failing. However, with this PR whenever any one fails of the input containers then you cannot perform the switch... which is somewhat fine if it weren't extremely hard to track down which of the items in the selection actually fail to switch. My proposal would be to merge this in the current state - however create a new issue that describes even better UX. A quick mockup here: It could potentially even show to which version it will end up resolving the switch Aside of that I noticed this version to be slightly slower, but nothing crazy that grinds it to a halt... :) just wanted to mention it. |
|
+1 for merge |
|
Let's merge it :D |

This PR add new functionality to asset switcher GUI in cbsceneinventory and improves in user experience in general.
Changes:
modelMainbut the asset I selected in the switcher doesn't have this subset, I won't be able to switch it and the subset dropdown will be coloured in red indicating I have to choose a new subset name.everything else should work identically so searching and the actual switch mechanism wasn't touched.
Here's the look of it
