Skip to content

chore(deps): update Android SDK to v7.3.0 #3434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 5, 2024
Merged

chore(deps): update Android SDK to v7.3.0 #3434

merged 2 commits into from
Feb 5, 2024

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Nov 30, 2023 •
edited
Loading

Bumps scripts/update-android.sh from 6.34.0 to 7.3.0.

Auto-generated by a dependency updater.

Changelog

7.3.0

Features

  • Added App Start profiling
    • This depends on the new option io.sentry.profiling.enable-app-start, other than the already existing io.sentry.traces.profiling.sample-rate.
    • Sampler functions can check the new isForNextAppStart flag, to adjust startup profiling sampling programmatically.
      Relevant PRs:
    • Decouple Profiler from Transaction (#3101)
    • Add options and sampling logic (#3121)
    • Add ContentProvider and start profile (#3128)
  • Extend internal performance collector APIs (#3102)
  • Collect slow and frozen frames for spans using OnFrameMetricsAvailableListener (#3111)
  • Interpolate total frame count to match span duration (#3158)

Fixes

  • Avoid multiple breadcrumbs from OkHttpEventListener (#3175)
  • Apply OkHttp listener auto finish timestamp to all running spans (#3167)
  • Fix not eligible for auto proxying warnings (#3154)
  • Set default fingerprint for ANRv2 events to correctly group background and foreground ANRs (#3164)
    • This will improve grouping of ANRs that have similar stacktraces but differ in background vs foreground state. Only affects newly-ingested ANR events with mechanism:AppExitInfo
  • Fix UserFeedback disk cache name conflicts with linked events (#3116)

Breaking changes

  • Remove HostnameVerifier option as it's flagged by security tools of some app stores (#3150)
    • If you were using this option, you have 3 possible paths going forward:
      • Provide a custom ITransportFactory through SentryOptions.setTransportFactory(), where you can copy over most of the parts like HttpConnection and AsyncHttpTransport from the SDK with necessary modifications
      • Get a certificate for your server through e.g. Let's Encrypt
      • Fork the SDK and add the hostname verifier back

Dependencies

7.2.0

Features

  • Handle monitor/check_in in client reports and rate limiter (#3096)
  • Add support for graphql-java version 21 (#3090)

Fixes

  • Avoid concurrency in AndroidProfiler performance data collection (#3130)
  • Improve thresholds for network changes breadcrumbs (#3083)
  • SchedulerFactoryBeanCustomizer now runs first so user customization is not overridden (#3095)
    • If you are setting global job listeners please also add SentryJobListener
  • Ensure serialVersionUID of Exception classes are unique (#3115)
  • Get rid of "is not eligible for getting processed by all BeanPostProcessors" warnings in Spring Boot (#3108)
  • Fix missing release and other fields for ANRs reported with mechanism:AppExitInfo (#3074)

Dependencies

  • Bump opentelemetry-sdk to 1.33.0 and opentelemetry-javaagent to 1.32.0 (#3112)

7.1.0

Features

  • Support multiple debug-metadata.properties (#3024)
  • Automatically downsample transactions when the system is under load (#3072)
    • You can opt into this behaviour by setting enable-backpressure-handling=true.
    • We're happy to receive feedback, e.g. in this GitHub issue
    • When the system is under load we start reducing the tracesSampleRate automatically.
    • Once the system goes back to healthy, we reset the tracesSampleRate to its original value.
  • (Android) Experimental: Provide more detailed cold app start information (#3057)
    • Attaches spans for Application, ContentProvider, and Activities to app-start timings
    • Application and ContentProvider timings are added using bytecode instrumentation, which requires sentry-android-gradle-plugin version 4.1.0 or newer
    • Uses Process.startUptimeMillis to calculate app-start timings
    • To enable this feature set options.isEnablePerformanceV2 = true
  • Move slow+frozen frame calculation, as well as frame delay inside SentryFrameMetricsCollector (#3100)
  • Extract Activity Breadcrumbs generation into own Integration (#3064)

Fixes

  • Send breadcrumbs and client error in SentryOkHttpEventListener even without transactions (#3087)
  • Keep io.sentry.exception.SentryHttpClientException from obfuscation to display proper issue title on Sentry (#3093)
  • (Android) Fix wrong activity transaction duration in case SDK init is deferred (#3092)

Dependencies

7.0.0

Version 7 of the Sentry Android/Java SDK brings a variety of features and fixes. The most notable changes are:

  • Bumping minSdk level to 19 (Android 4.4)
  • The SDK will now listen to connectivity changes and try to re-upload cached events when internet connection is re-established additionally to uploading events on app restart
  • Sentry.getSpan now returns the root transaction, which should improve the span hierarchy and make it leaner
  • Multiple improvements to reduce probability of the SDK causing ANRs
  • New sentry-okhttp artifact is unbundled from Android and can be used in pure JVM-only apps

Sentry Self-hosted Compatibility

This SDK version is compatible with a self-hosted version of Sentry 22.12.0 or higher. If you are using an older version of self-hosted Sentry (aka onpremise), you will need to upgrade. If you're using sentry.io no action is required.

Sentry Integrations Version Compatibility (Android)

Make sure to align all Sentry dependencies to the same version when bumping the SDK to 7.+, otherwise it will crash at runtime due to binary incompatibility. (E.g. if you're using -timber, -okhttp or other packages)

For example, if you're using the Sentry Android Gradle plugin with the autoInstallation feature (enabled by default), make sure to use version 4.+ of the gradle plugin together with version 7.+ of the SDK. If you can't do that for some reason, you can specify sentry version via the plugin config block:

sentry {
  autoInstallation {
    sentryVersion.set("7.0.0")
  }
}

Similarly, if you have a Sentry SDK (e.g. sentry-android-core) dependency on one of your Gradle modules and you're updating it to 7.+, make sure the Gradle plugin is at 4.+ or specify the SDK version as shown in the snippet above.

Breaking Changes

  • Bump min API to 19 (#2883)
  • If you're using sentry-kotlin-extensions, it requires kotlinx-coroutines-core version 1.6.1 or higher now (#2838)
  • Move enableNdk from SentryOptions to SentryAndroidOptions (#2793)
  • Apollo v2 BeforeSpanCallback now allows returning null (#2890)
  • SentryOkHttpUtils was removed from public API as it's been exposed by mistake (#3005)
  • Scope now implements the IScope interface, therefore some methods like ScopeCallback.run accept IScope now (#3066)
  • Cleanup startTransaction overloads (#2964)
    • We have reduced the number of overloads by allowing to pass in a TransactionOptions object instead of having separate parameters for certain options
    • TransactionOptions has defaults set and can be customized, for example:
// old
val transaction = Sentry.startTransaction("name", "op", bindToScope = true)
// new
val transaction = Sentry.startTransaction("name", "op", TransactionOptions().apply { isBindToScope = true })

Behavioural Changes

  • Android only: Sentry.getSpan() returns the root span/transaction instead of the latest span (#2855)
  • Capture failed HTTP and GraphQL (Apollo) requests by default (#2794)
    • This can increase your event consumption and may affect your quota, because we will report failed network requests as Sentry events by default, if you're using the sentry-android-okhttp or sentry-apollo-3 integrations. You can customize what errors you want/don't want to have reported for OkHttp and Apollo3 respectively.
  • Measure AppStart time till First Draw instead of onResume (#2851)
  • Automatic user interaction tracking: every click now starts a new automatic transaction (#2891)
    • Previously performing a click on the same UI widget twice would keep the existing transaction running, the new behavior now better aligns with other SDKs
  • Add deadline timeout for automatic transactions (#2865)
    • This affects all automatically generated transactions on Android (UI, clicks), the default timeout is 30s, meaning the automatic transaction will be force-finished with status deadline_exceeded when reaching the deadline
  • Set ip_address to {{auto}} by default, even if sendDefaultPII is disabled (#2860)
    • Instead use the "Prevent Storing of IP Addresses" option in the "Security & Privacy" project settings on sentry.io
  • Raw logback message and parameters are now guarded by sendDefaultPii if an encoder has been configured (#2976)
  • The maxSpans setting (defaults to 1000) is enforced for nested child spans which means a single transaction can have maxSpans number of children (nested or not) at most (#3065)
  • The ScopeCallback in withScope is now always executed (#3066)

Deprecations

  • sentry-android-okhttp was deprecated in favour of the new sentry-okhttp module. Make sure to replace io.sentry.android.okhttp package name with io.sentry.okhttp before the next major, where the classes will be removed (#3005)

Other Changes

Features

  • Observe network state to upload any unsent envelopes (#2910)
  • Add sentry-okhttp module to support instrumenting OkHttp in non-Android projects (#3005)
  • Do not filter out Sentry SDK frames in case of uncaught exceptions (#3021)
  • Do not try to send and drop cached envelopes when rate-limiting is active (#2937)

Fixes

  • Use getMyMemoryState() instead of getRunningAppProcesses() to retrieve process importance (#3004)
    • This should prevent some app stores from flagging apps as violating their privacy
  • Reduce flush timeout to 4s on Android to avoid ANRs (#2858)
  • Reduce timeout of AsyncHttpTransport to avoid ANR (#2879)
  • Do not overwrite UI transaction status if set by the user (#2852)
  • Capture unfinished transaction on Scope with status aborted in case a crash happens (#2938)
    • This will fix the link between transactions and corresponding crashes, you'll be able to see them in a single trace
  • Fix Coroutine Context Propagation using CopyableThreadContextElement (#2838)
  • Fix don't overwrite the span status of unfinished spans (#2859)
  • Migrate from default interface methods to proper implementations in each interface implementor (#2847)
    • This prevents issues when using the SDK on older AGP versions (< 4.x.x)
  • Reduce main thread work on init (#3036)
  • Move Integrations registration to background on init (#3043)
  • Fix SentryOkHttpInterceptor.BeforeSpanCallback was not finishing span when it was dropped (#2958)

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Nov 30, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from b5bd422 to 265982c Compare November 30, 2023 13:50
@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 30, 2023 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1206.94 ms 1210.67 ms 3.73 ms
Size 2.36 MiB 2.88 MiB 527.16 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9433f35+dirty 1246.94 ms 1271.45 ms 24.52 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
1d86dd6+dirty 1249.71 ms 1279.16 ms 29.45 ms
d361d38+dirty 1246.04 ms 1267.12 ms 21.08 ms
12427f4+dirty 1267.15 ms 1271.30 ms 4.15 ms
6e8584e+dirty 1274.50 ms 1296.82 ms 22.32 ms
3ffcddd+dirty 1244.47 ms 1264.14 ms 19.67 ms
22e31b6+dirty 1253.62 ms 1265.96 ms 12.34 ms
0677344+dirty 1276.70 ms 1300.07 ms 23.37 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms

App size

Revision Plain With Sentry Diff
9433f35+dirty 2.36 MiB 2.85 MiB 499.80 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
1d86dd6+dirty 2.36 MiB 2.89 MiB 535.43 KiB
d361d38+dirty 2.36 MiB 2.85 MiB 499.84 KiB
12427f4+dirty 2.36 MiB 2.88 MiB 530.38 KiB
6e8584e+dirty 2.36 MiB 2.88 MiB 533.17 KiB
3ffcddd+dirty 2.36 MiB 2.84 MiB 489.60 KiB
22e31b6+dirty 2.36 MiB 2.87 MiB 520.67 KiB
0677344+dirty 2.36 MiB 2.85 MiB 496.81 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB

Previous results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
111c58e+dirty 1265.76 ms 1271.32 ms 5.56 ms
6222f43+dirty 1247.86 ms 1262.94 ms 15.08 ms
80e039e+dirty 1218.47 ms 1228.74 ms 10.27 ms
8d763c2+dirty 1256.46 ms 1284.62 ms 28.16 ms
107b129+dirty 1257.08 ms 1267.98 ms 10.90 ms
59de53f+dirty 1254.08 ms 1276.02 ms 21.94 ms
2e9a42f+dirty 1274.18 ms 1284.52 ms 10.34 ms
fa42167+dirty 1239.02 ms 1239.22 ms 0.20 ms
ad7319a+dirty 1215.82 ms 1236.38 ms 20.56 ms
cd98a44+dirty 1253.20 ms 1273.48 ms 20.28 ms

App size

Revision Plain With Sentry Diff
111c58e+dirty 2.36 MiB 2.85 MiB 496.85 KiB
6222f43+dirty 2.36 MiB 2.88 MiB 532.92 KiB
80e039e+dirty 2.36 MiB 2.88 MiB 531.89 KiB
8d763c2+dirty 2.36 MiB 2.88 MiB 533.06 KiB
107b129+dirty 2.36 MiB 2.82 MiB 469.43 KiB
59de53f+dirty 2.36 MiB 2.87 MiB 520.66 KiB
2e9a42f+dirty 2.36 MiB 2.85 MiB 499.83 KiB
fa42167+dirty 2.36 MiB 2.85 MiB 495.31 KiB
ad7319a+dirty 2.36 MiB 2.87 MiB 520.67 KiB
cd98a44+dirty 2.36 MiB 2.87 MiB 520.20 KiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 30, 2023 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1254.61 ms 1255.86 ms 1.24 ms
Size 2.92 MiB 3.44 MiB 531.16 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9433f35+dirty 1232.24 ms 1232.74 ms 0.50 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
1d86dd6+dirty 1289.25 ms 1293.36 ms 4.11 ms
d361d38+dirty 1272.96 ms 1291.70 ms 18.74 ms
12427f4+dirty 1224.90 ms 1231.40 ms 6.50 ms
6e8584e+dirty 1271.71 ms 1281.26 ms 9.55 ms
3ffcddd+dirty 1272.22 ms 1273.98 ms 1.76 ms
22e31b6+dirty 1276.55 ms 1278.12 ms 1.57 ms
0677344+dirty 1252.52 ms 1254.08 ms 1.56 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms

App size

Revision Plain With Sentry Diff
9433f35+dirty 2.92 MiB 3.41 MiB 503.55 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
1d86dd6+dirty 2.92 MiB 3.44 MiB 538.27 KiB
d361d38+dirty 2.92 MiB 3.41 MiB 503.57 KiB
12427f4+dirty 2.92 MiB 3.44 MiB 533.29 KiB
6e8584e+dirty 2.92 MiB 3.44 MiB 536.52 KiB
3ffcddd+dirty 2.92 MiB 3.40 MiB 494.39 KiB
22e31b6+dirty 2.92 MiB 3.43 MiB 524.74 KiB
0677344+dirty 2.92 MiB 3.41 MiB 500.94 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB

Previous results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
111c58e+dirty 1219.08 ms 1238.76 ms 19.67 ms
6222f43+dirty 1259.68 ms 1261.64 ms 1.96 ms
80e039e+dirty 1266.88 ms 1275.52 ms 8.64 ms
8d763c2+dirty 1296.18 ms 1311.02 ms 14.84 ms
107b129+dirty 1261.74 ms 1269.16 ms 7.42 ms
59de53f+dirty 1288.46 ms 1293.40 ms 4.95 ms
2e9a42f+dirty 1248.31 ms 1248.52 ms 0.21 ms
fa42167+dirty 1290.73 ms 1315.08 ms 24.35 ms
ad7319a+dirty 1235.78 ms 1239.62 ms 3.84 ms
cd98a44+dirty 1303.06 ms 1307.82 ms 4.76 ms

App size

Revision Plain With Sentry Diff
111c58e+dirty 2.92 MiB 3.41 MiB 501.00 KiB
6222f43+dirty 2.92 MiB 3.44 MiB 536.26 KiB
80e039e+dirty 2.92 MiB 3.44 MiB 535.20 KiB
8d763c2+dirty 2.92 MiB 3.44 MiB 536.46 KiB
107b129+dirty 2.92 MiB 3.38 MiB 475.70 KiB
59de53f+dirty 2.92 MiB 3.43 MiB 524.73 KiB
2e9a42f+dirty 2.92 MiB 3.41 MiB 503.53 KiB
fa42167+dirty 2.92 MiB 3.41 MiB 499.08 KiB
ad7319a+dirty 2.92 MiB 3.43 MiB 524.67 KiB
cd98a44+dirty 2.92 MiB 3.43 MiB 524.25 KiB

@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 8 times, most recently from fa38d56 to 9bce062 Compare December 7, 2023 10:51
@github-actions github-actions bot changed the title chore(deps): update Android SDK to v7.0.0 chore(deps): update Android SDK to v7.1.0 Dec 19, 2023
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 3 times, most recently from 13efed6 to 6147861 Compare December 22, 2023 13:09
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 6 times, most recently from 6871573 to fc48aec Compare January 10, 2024 14:25
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from fc48aec to a0f799d Compare January 12, 2024 14:06
@github-actions github-actions bot changed the title chore(deps): update Android SDK to v7.1.0 chore(deps): update Android SDK to v7.2.0 Jan 12, 2024
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 4 times, most recently from 8215d44 to 99b71b4 Compare January 18, 2024 09:43
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 10 times, most recently from 1d72257 to 58cc017 Compare January 25, 2024 05:09
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 2 times, most recently from 1c60eee to b6b131d Compare January 30, 2024 18:21
@github-actions github-actions bot changed the title chore(deps): update Android SDK to v7.2.0 chore(deps): update Android SDK to v7.3.0 Jan 30, 2024
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch 5 times, most recently from 636533b to 001a071 Compare February 1, 2024 15:26
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-android.sh branch from 001a071 to 0fadf67 Compare February 5, 2024 08:39
@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 5, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.71 ms 510.57 ms 59.86 ms
Size 17.73 MiB 19.86 MiB 2.12 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
728164b 414.34 ms 449.22 ms 34.88 ms
34aba08 328.10 ms 342.84 ms 14.74 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
e73f4ed+dirty 332.96 ms 354.33 ms 21.37 ms
9433f35 347.64 ms 356.22 ms 8.58 ms
457e29f 398.10 ms 421.39 ms 23.29 ms
86d6d2c+dirty 332.90 ms 352.45 ms 19.55 ms
3853f43 329.68 ms 346.32 ms 16.64 ms
2534337 394.15 ms 415.12 ms 20.97 ms
3ffcddd 302.92 ms 315.80 ms 12.88 ms

App size

Revision Plain With Sentry Diff
728164b 17.73 MiB 19.85 MiB 2.12 MiB
34aba08 17.73 MiB 19.80 MiB 2.07 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
e73f4ed+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9433f35 17.73 MiB 19.81 MiB 2.08 MiB
457e29f 17.73 MiB 19.84 MiB 2.10 MiB
86d6d2c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
3853f43 17.73 MiB 19.81 MiB 2.08 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
3ffcddd 17.73 MiB 19.75 MiB 2.02 MiB

Previous results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
bf931f5+dirty 346.46 ms 394.20 ms 47.75 ms
fa42167 335.87 ms 355.96 ms 20.09 ms
e570815 410.80 ms 430.00 ms 19.20 ms
6222f43 420.96 ms 446.28 ms 25.32 ms
59de53f 388.17 ms 435.58 ms 47.41 ms
2e9a42f 358.96 ms 384.77 ms 25.81 ms
111c58e 313.04 ms 316.54 ms 3.50 ms
80e039e 403.14 ms 426.94 ms 23.80 ms
cd98a44 491.98 ms 596.15 ms 104.17 ms
ae87f29 442.48 ms 466.00 ms 23.52 ms

App size

Revision Plain With Sentry Diff
bf931f5+dirty 17.73 MiB 19.75 MiB 2.02 MiB
fa42167 17.73 MiB 19.80 MiB 2.07 MiB
e570815 17.73 MiB 19.85 MiB 2.12 MiB
6222f43 17.73 MiB 19.86 MiB 2.12 MiB
59de53f 17.73 MiB 19.84 MiB 2.10 MiB
2e9a42f 17.73 MiB 19.81 MiB 2.08 MiB
111c58e 17.73 MiB 19.81 MiB 2.07 MiB
80e039e 17.73 MiB 19.85 MiB 2.12 MiB
cd98a44 17.73 MiB 19.83 MiB 2.10 MiB
ae87f29 17.73 MiB 19.85 MiB 2.12 MiB

@github-actions
Copy link
Contributor Author

github-actions bot commented Feb 5, 2024

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 340.60 ms 372.68 ms 32.09 ms
Size 7.15 MiB 8.13 MiB 1010.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5446992+dirty 371.61 ms 390.00 ms 18.39 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
e73f4ed+dirty 262.98 ms 311.02 ms 48.04 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
9433f35+dirty 265.50 ms 336.08 ms 70.58 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
86d6d2c+dirty 267.21 ms 325.24 ms 58.04 ms
12427f4+dirty 379.48 ms 400.92 ms 21.44 ms
abb7058+dirty 320.78 ms 324.08 ms 3.30 ms

App size

Revision Plain With Sentry Diff
5446992+dirty 7.15 MiB 8.12 MiB 999.45 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
e73f4ed+dirty 7.15 MiB 8.09 MiB 965.94 KiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
9433f35+dirty 7.15 MiB 8.08 MiB 959.34 KiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
86d6d2c+dirty 7.15 MiB 8.09 MiB 962.69 KiB
12427f4+dirty 7.15 MiB 8.12 MiB 997.78 KiB
abb7058+dirty 7.15 MiB 8.10 MiB 980.40 KiB

Previous results on branch: deps/scripts/update-android.sh

Startup times

Revision Plain With Sentry Diff
bf931f5+dirty 257.49 ms 300.92 ms 43.43 ms
8d763c2+dirty 352.61 ms 377.30 ms 24.69 ms
2e9a42f+dirty 281.55 ms 334.18 ms 52.63 ms
6222f43+dirty 339.49 ms 379.51 ms 40.02 ms
80e039e+dirty 334.59 ms 352.43 ms 17.84 ms
cd98a44+dirty 345.19 ms 374.66 ms 29.47 ms
fa42167+dirty 270.35 ms 291.58 ms 21.23 ms
111c58e+dirty 265.72 ms 332.72 ms 67.00 ms
59de53f+dirty 362.75 ms 400.38 ms 37.63 ms
ae87f29+dirty 369.92 ms 407.58 ms 37.66 ms

App size

Revision Plain With Sentry Diff
bf931f5+dirty 7.15 MiB 8.04 MiB 910.84 KiB
8d763c2+dirty 7.15 MiB 8.13 MiB 1002.69 KiB
2e9a42f+dirty 7.15 MiB 8.08 MiB 959.34 KiB
6222f43+dirty 7.15 MiB 8.13 MiB 1002.31 KiB
80e039e+dirty 7.15 MiB 8.12 MiB 999.91 KiB
cd98a44+dirty 7.15 MiB 8.10 MiB 979.68 KiB
fa42167+dirty 7.15 MiB 8.07 MiB 947.70 KiB
111c58e+dirty 7.15 MiB 8.07 MiB 950.00 KiB
59de53f+dirty 7.15 MiB 8.11 MiB 983.75 KiB
ae87f29+dirty 7.15 MiB 8.12 MiB 999.34 KiB

krystofwoldrich
krystofwoldrich approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

We can merge after CI is done.

@krystofwoldrich krystofwoldrich mentioned this pull request Feb 5, 2024
Closed
@krystofwoldrich krystofwoldrich merged commit cbee1f9 into main Feb 5, 2024
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-android.sh branch February 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

1 more reviewer

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krystofwoldrich @web-flow