feat(replay): iOS: Adds enableExperimentalViewRenderer and enableFastViewRendering
#4660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom sentry-cocoa
|
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4bd70f | 438.35 ms | 442.18 ms | 3.84 ms |
| c71ea72 | 492.79 ms | 478.78 ms | -14.01 ms |
| 76d1baf+dirty | 335.72 ms | 355.52 ms | 19.80 ms |
| 6707be9 | 445.04 ms | 464.24 ms | 19.20 ms |
| ddc0552 | 472.92 ms | 460.66 ms | -12.26 ms |
| c2a4e9b | 480.42 ms | 485.60 ms | 5.18 ms |
| 31fcca2 | 391.22 ms | 414.78 ms | 23.56 ms |
| 05b43ab | 438.67 ms | 496.19 ms | 57.52 ms |
| 0db0c72 | 372.12 ms | 386.00 ms | 13.88 ms |
| d997097 | 470.23 ms | 475.46 ms | 5.23 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c4bd70f | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| c71ea72 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 76d1baf+dirty | 17.73 MiB | 20.04 MiB | 2.31 MiB |
| 6707be9 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| ddc0552 | 17.74 MiB | 20.09 MiB | 2.35 MiB |
| c2a4e9b | 17.73 MiB | 20.06 MiB | 2.33 MiB |
| 31fcca2 | 17.73 MiB | 19.90 MiB | 2.17 MiB |
| 05b43ab | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| 0db0c72 | 17.73 MiB | 19.75 MiB | 2.02 MiB |
| d997097 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 457e29f+dirty | 591.49 ms | 612.96 ms | 21.47 ms |
| 025d490+dirty | 393.10 ms | 402.53 ms | 9.43 ms |
| 148f924+dirty | 347.36 ms | 389.13 ms | 41.77 ms |
| 52c0562+dirty | 401.23 ms | 435.65 ms | 34.42 ms |
| b7eb05d+dirty | 335.90 ms | 338.98 ms | 3.08 ms |
| 15c80ab+dirty | 276.38 ms | 327.54 ms | 51.17 ms |
| 7fd512a+dirty | 439.69 ms | 503.71 ms | 64.01 ms |
| 6fd1d2b+dirty | 426.36 ms | 453.98 ms | 27.62 ms |
| fe13591+dirty | 539.51 ms | 597.92 ms | 58.40 ms |
| 86d6d2c+dirty | 267.21 ms | 325.24 ms | 58.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 457e29f+dirty | 7.15 MiB | 8.10 MiB | 981.29 KiB |
| 025d490+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 148f924+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
| 52c0562+dirty | 7.15 MiB | 8.39 MiB | 1.24 MiB |
| b7eb05d+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 15c80ab+dirty | 7.15 MiB | 8.09 MiB | 966.13 KiB |
| 7fd512a+dirty | 7.15 MiB | 8.35 MiB | 1.21 MiB |
| 6fd1d2b+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| fe13591+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 86d6d2c+dirty | 7.15 MiB | 8.09 MiB | 962.69 KiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f86dde7+dirty | 1219.88 ms | 1224.58 ms | 4.71 ms |
| 4297324+dirty | 1240.86 ms | 1232.04 ms | -8.81 ms |
| e4d9fe0+dirty | 1210.45 ms | 1204.23 ms | -6.21 ms |
| 05b43ab+dirty | 1231.12 ms | 1235.83 ms | 4.70 ms |
| 3aecc61+dirty | 1240.27 ms | 1240.51 ms | 0.24 ms |
| 025d490+dirty | 1205.27 ms | 1206.15 ms | 0.88 ms |
| c71ea72+dirty | 1221.39 ms | 1231.77 ms | 10.38 ms |
| d8992c6+dirty | 1206.27 ms | 1216.76 ms | 10.48 ms |
| 8ab11b6+dirty | 1222.91 ms | 1216.08 ms | -6.83 ms |
| fe13591+dirty | 1250.69 ms | 1246.27 ms | -4.43 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f86dde7+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 4297324+dirty | 2.92 MiB | 3.64 MiB | 741.22 KiB |
| e4d9fe0+dirty | 3.19 MiB | 4.26 MiB | 1.08 MiB |
| 05b43ab+dirty | 3.19 MiB | 4.30 MiB | 1.12 MiB |
| 3aecc61+dirty | 2.92 MiB | 3.69 MiB | 789.88 KiB |
| 025d490+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| c71ea72+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| d8992c6+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 8ab11b6+dirty | 2.92 MiB | 3.67 MiB | 772.38 KiB |
| fe13591+dirty | 2.92 MiB | 3.66 MiB | 757.71 KiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f86dde7+dirty | 1204.88 ms | 1203.61 ms | -1.26 ms |
| 4297324+dirty | 1230.27 ms | 1232.53 ms | 2.27 ms |
| e4d9fe0+dirty | 1221.43 ms | 1238.51 ms | 17.08 ms |
| 05b43ab+dirty | 1225.33 ms | 1227.33 ms | 2.00 ms |
| 3aecc61+dirty | 1237.75 ms | 1237.42 ms | -0.33 ms |
| 025d490+dirty | 1237.51 ms | 1238.34 ms | 0.83 ms |
| c71ea72+dirty | 1225.76 ms | 1229.51 ms | 3.76 ms |
| d8992c6+dirty | 1236.55 ms | 1241.53 ms | 4.98 ms |
| 8ab11b6+dirty | 1203.23 ms | 1206.02 ms | 2.79 ms |
| fe13591+dirty | 1208.25 ms | 1219.53 ms | 11.28 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f86dde7+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 4297324+dirty | 2.36 MiB | 3.08 MiB | 735.61 KiB |
| e4d9fe0+dirty | 2.63 MiB | 3.70 MiB | 1.06 MiB |
| 05b43ab+dirty | 2.63 MiB | 3.74 MiB | 1.11 MiB |
| 3aecc61+dirty | 2.36 MiB | 3.12 MiB | 778.58 KiB |
| 025d490+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| c71ea72+dirty | 2.63 MiB | 3.68 MiB | 1.05 MiB |
| d8992c6+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 8ab11b6+dirty | 2.36 MiB | 3.11 MiB | 759.83 KiB |
| fe13591+dirty | 2.36 MiB | 3.10 MiB | 752.40 KiB |
7 tasks
antonis
commented
Mar 14, 2025
packages/core/RNSentryCocoaTester/RNSentryCocoaTesterTests/RNSentryReplayOptionsTests.swift
Show resolved
Hide resolved
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
This was referenced Mar 18, 2025
|
Hey everyone, Thanks a lot for the work on improving this! Hoping this makes it to the finish line soon, let me know if there's anything i can do to help. We're currently blocked from releasing our app with sentry replays integration due to a noticeable drop in frame rate. Looking forward to trying this and seeing if that solves it in our react-native app! |
lucas-zimerman
approved these changes
Mar 19, 2025
Co-authored-by: LucasZF <[email protected]>
krystofwoldrich
approved these changes
Mar 20, 2025
krystofwoldrich
pushed a commit
that referenced
this pull request
Mar 25, 2025
…wRendering` for iOS (#4660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Depends on getsentry/sentry-cocoa#4988
📜 Description
Adds
enableExperimentalViewRendererandenableFastViewRenderingmobile replay options from sentry-cocoa💡 Motivation and Context
Fixes #4658
💚 How did you test it?
Sample App, CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps