-
-
Notifications
You must be signed in to change notification settings - Fork 349
feat(replay): iOS: Adds enableExperimentalViewRenderer
and enableFastViewRendering
#4660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
00a3d36
Adds `enableExperimentalViewRenderer` and `enableFastViewRendering` f…
antonis e53a4d7
Adds changelog
antonis 8118fe7
Fixes broken test
antonis 65533d8
Fixes lint issue
antonis 920746b
Adds tests
antonis bfb478d
Merge branch 'main' into antonis/4658-ExperimentalViewRenderer
antonis 6799657
Fix comment typo
antonis 453329b
Merge branch 'main' into antonis/4658-ExperimentalViewRenderer
antonis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -48,13 +48,15 @@ final class RNSentryReplayOptions: XCTestCase { | |
} | ||
|
||
func assertAllDefaultReplayOptionsAreNotNil(replayOptions: [String: Any]) { | ||
XCTAssertEqual(replayOptions.count, 6) | ||
XCTAssertEqual(replayOptions.count, 8) | ||
XCTAssertNotNil(replayOptions["sessionSampleRate"]) | ||
XCTAssertNotNil(replayOptions["errorSampleRate"]) | ||
XCTAssertNotNil(replayOptions["maskAllImages"]) | ||
XCTAssertNotNil(replayOptions["maskAllText"]) | ||
XCTAssertNotNil(replayOptions["maskedViewClasses"]) | ||
XCTAssertNotNil(replayOptions["sdkInfo"]) | ||
XCTAssertNotNil(replayOptions["enableExperimentalViewRenderer"]) | ||
XCTAssertNotNil(replayOptions["enableFastViewRendering"]) | ||
} | ||
|
||
func testSessionSampleRate() { | ||
|
@@ -164,5 +166,87 @@ final class RNSentryReplayOptions: XCTestCase { | |
XCTAssertEqual(actualOptions.sessionReplay.maskAllText, false) | ||
XCTAssertEqual(actualOptions.sessionReplay.maskedViewClasses.count, 0) | ||
} | ||
|
||
func testEnableExperimentalViewRendererDefault() { | ||
let optionsDict = ([ | ||
"dsn": "https://[email protected]/1234567", | ||
"replaysOnErrorSampleRate": 0.75 | ||
] as NSDictionary).mutableCopy() as! NSMutableDictionary | ||
|
||
RNSentryReplay.updateOptions(optionsDict) | ||
|
||
let actualOptions = try! Options(dict: optionsDict as! [String: Any]) | ||
|
||
XCTAssertFalse(actualOptions.sessionReplay.enableExperimentalViewRenderer) | ||
} | ||
|
||
func testEnableExperimentalViewRendererTrue() { | ||
let optionsDict = ([ | ||
"dsn": "https://[email protected]/1234567", | ||
"replaysOnErrorSampleRate": 0.75, | ||
"mobileReplayOptions": [ "enableExperimentalViewRenderer": true ] | ||
] as NSDictionary).mutableCopy() as! NSMutableDictionary | ||
|
||
RNSentryReplay.updateOptions(optionsDict) | ||
|
||
let actualOptions = try! Options(dict: optionsDict as! [String: Any]) | ||
|
||
XCTAssertTrue(actualOptions.sessionReplay.enableExperimentalViewRenderer) | ||
} | ||
|
||
func testEnableExperimentalViewRendererFalse() { | ||
let optionsDict = ([ | ||
"dsn": "https://[email protected]/1234567", | ||
"replaysOnErrorSampleRate": 0.75, | ||
"mobileReplayOptions": [ "enableExperimentalViewRenderer": false ] | ||
] as NSDictionary).mutableCopy() as! NSMutableDictionary | ||
|
||
RNSentryReplay.updateOptions(optionsDict) | ||
|
||
let actualOptions = try! Options(dict: optionsDict as! [String: Any]) | ||
|
||
XCTAssertFalse(actualOptions.sessionReplay.enableExperimentalViewRenderer) | ||
} | ||
|
||
func testEnableFastViewRenderingDefault() { | ||
let optionsDict = ([ | ||
"dsn": "https://[email protected]/1234567", | ||
"replaysOnErrorSampleRate": 0.75 | ||
] as NSDictionary).mutableCopy() as! NSMutableDictionary | ||
|
||
RNSentryReplay.updateOptions(optionsDict) | ||
|
||
let actualOptions = try! Options(dict: optionsDict as! [String: Any]) | ||
|
||
XCTAssertFalse(actualOptions.sessionReplay.enableFastViewRendering) | ||
} | ||
|
||
func testEnableFastViewRenderingTrue() { | ||
let optionsDict = ([ | ||
"dsn": "https://[email protected]/1234567", | ||
"replaysOnErrorSampleRate": 0.75, | ||
"mobileReplayOptions": [ "enableFastViewRendering": true ] | ||
] as NSDictionary).mutableCopy() as! NSMutableDictionary | ||
|
||
RNSentryReplay.updateOptions(optionsDict) | ||
|
||
let actualOptions = try! Options(dict: optionsDict as! [String: Any]) | ||
|
||
XCTAssertTrue(actualOptions.sessionReplay.enableFastViewRendering) | ||
} | ||
|
||
func testEnableFastViewRenderingFalse() { | ||
let optionsDict = ([ | ||
"dsn": "https://[email protected]/1234567", | ||
"replaysOnErrorSampleRate": 0.75, | ||
"mobileReplayOptions": [ "enableFastViewRendering": false ] | ||
] as NSDictionary).mutableCopy() as! NSMutableDictionary | ||
|
||
RNSentryReplay.updateOptions(optionsDict) | ||
|
||
let actualOptions = try! Options(dict: optionsDict as! [String: Any]) | ||
|
||
XCTAssertFalse(actualOptions.sessionReplay.enableFastViewRendering) | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.