ref(crons): Improve typing on MONITOR_CODEC #69919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69919 +/- ##
==========================================
+ Coverage 78.96% 79.86% +0.90%
==========================================
Files 6490 6490
Lines 288562 288566 +4
Branches 49692 49692
==========================================
+ Hits 227851 230467 +2616
+ Misses 60314 57703 -2611
+ Partials 397 396 -1
|
evanpurkhiser
commented
Apr 29, 2024
| logger = logging.getLogger(__name__) | ||
|
|
||
| MONITOR_CODEC = get_codec("ingest-monitors") | ||
| MONITOR_CODEC: Codec[IngestMonitorMessage] = get_codec("ingest-monitors") |
There was a problem hiding this comment.
Helps the codec understand it's going to be encoding / decoding a IngestMonitorMessage
anonrig
approved these changes
Apr 29, 2024
evanpurkhiser
deleted the
evanpurkhiser/ref-crons-improve-typing-on-monitor-codec
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.