Skip to content

ref(crons): Improve typing on MONITOR_CODEC #69919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2024
Merged

ref(crons): Improve typing on MONITOR_CODEC #69919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sentry/monitors/consumers/monitor_consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
from arroyo.types import BrokerValue, Commit, FilteredPayload, Message, Partition
from django.db import router, transaction
from sentry_kafka_schemas import get_codec
from sentry_kafka_schemas.codecs import Codec
from sentry_kafka_schemas.schema_types.ingest_monitors_v1 import IngestMonitorMessage
from sentry_sdk.tracing import Span, Transaction

Expand Down Expand Up @@ -57,7 +58,7 @@

logger = logging.getLogger(__name__)

MONITOR_CODEC = get_codec("ingest-monitors")
MONITOR_CODEC: Codec[IngestMonitorMessage] = get_codec("ingest-monitors")
Copy link
Member Author

@evanpurkhiser evanpurkhiser Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helps the codec understand it's going to be encoding / decoding a IngestMonitorMessage


CHECKIN_QUOTA_LIMIT = 6
CHECKIN_QUOTA_WINDOW = 60
Expand Down