fix(staff): Remove incorrrect u2f error message #70362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
dashed
reviewed
May 6, 2024
Co-authored-by: Alberto Leal <[email protected]>
dashed
approved these changes
May 6, 2024
|
|
||
| await this.getAuthenticators(); | ||
| const authenticators = await this.getAuthenticators(); | ||
| this.setState({authenticators: authenticators}); |
Member
There was a problem hiding this comment.
I don't see this state being modified anywhere else. Does it even need to be state?
Contributor
Author
There was a problem hiding this comment.
Would removing it look like this? #70365
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes the random u2f error msg popping up when it shouldn't be