Skip to content

fix(staff): Remove incorrrect u2f error message #70362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2024
Merged

fix(staff): Remove incorrrect u2f error message #70362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d3f8c
fix(staff): Remove incorrrect u2f error message
schew2381 May 6, 2024
15c9b54
Update static/app/components/superuserStaffAccessForm.tsx
schew2381 May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions static/app/components/superuserStaffAccessForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,11 @@ class SuperuserStaffAccessForm extends Component<Props, State> {
return;
}

await this.getAuthenticators();
const authenticators = await this.getAuthenticators();
this.setState({authenticators: authenticators});
Copy link
Member

@sentaur-athena sentaur-athena May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see this state being modified anywhere else. Does it even need to be state?

Copy link
Contributor Author

@schew2381 schew2381 May 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would removing it look like this? #70365


// Set the error state if there are no authenticators and U2F is on
if (!this.state.authenticators.length && !disableU2FForSUForm) {
if (!authenticators.length && !disableU2FForSUForm) {
this.handleError(ErrorCodes.NO_AUTHENTICATOR);
}
this.setState({isLoading: false});
Expand Down Expand Up @@ -183,10 +185,11 @@ class SuperuserStaffAccessForm extends Component<Props, State> {

try {
const authenticators = await api.requestPromise('/authenticators/');
this.setState({authenticators: authenticators ?? []});
return authenticators ?? [];
} catch {
// ignore errors
}
return [];
}

render() {
Expand Down