feat(trace-explorer): Supports metrics min/max #70920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Zylphrex
force-pushed
the
txiao/feat/support-metrics-min-max-for-trace-explorer
branch
from
869a639 to
ec516e2
Compare
Metrics allow selecting a region on the graph to bound the date selection as well as min/max. Date selection can be supported via the existing params but this adds a metricsMin and metricsMax param to support the metrics bounds.
Zylphrex
force-pushed
the
txiao/feat/support-metrics-min-max-for-trace-explorer
branch
from
ec516e2 to
54a56f5
Compare
matejminar
approved these changes
May 15, 2024
Zylphrex
deleted the
txiao/feat/support-metrics-min-max-for-trace-explorer
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metrics allow selecting a region on the graph to bound the date selection as well as min/max. Date selection can be supported via the existing params but this adds a metricsMin and metricsMax param to support the metrics bounds.