ref(api): Refactor Org Serializers to Selectively Include feature flags #71791
Conversation
github-actions
bot
added
the
Scope: Backend
| from sentry import experiments | ||
|
|
||
| experiment_assignments = experiments.all(org=obj, actor=user) | ||
| include_feature_flags = kwargs.get("include_feature_flags", True) |
There was a problem hiding this comment.
we should include the flag if the kwarg isn't passed in.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71791 +/- ##
===========================================
+ Coverage 56.83% 77.90% +21.07%
===========================================
Files 6545 6554 +9
Lines 291881 292194 +313
Branches 50423 50473 +50
===========================================
+ Hits 165897 227642 +61745
+ Misses 121231 58299 -62932
- Partials 4753 6253 +1500
|
ykamo001
left a comment
ykamo001
left a comment
There was a problem hiding this comment.
Love the work here @iamrajjoshi! I think we can clean this up a little and make it more modular and easier to extend for the future, going to put some time on the calendar
We can do this in a follow up, so no rush! |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
When an organization changes their slug we should redirect to the new slug. This isn't working currently because of changes to OrganizationDetails that elide `features` by default. (#71791) As customer-domains will soon be retried and replaced with a system configuration feature flag, I've chosen to adapt the logic for org details settings to read from `ConfigStore` like it will in the future. Fixes HC-1096
Followup on #71668
I refactored the serializers here so they accept a new kwarg -
include_feature_flag. if the kwarg is passed, it will only determine thefeaturesfield if the flag isTrue.This should reduce the amount of computation that we do if the response doesn't require feature flags.