fix(ui) Fix broken redirect on org rename #72906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an organization changes their slug we should redirect to the new slug. This isn't working currently because of changes to OrganizationDetails that elide `features` by default. As customer-domains will soon be retried and replaced with a system configuration feature flag, I've chosen to adapt the logic for org details settings to read from `ConfigStore` like it will in the future. Fixes HC-1096
github-actions
bot
added
the
Scope: Frontend
Bundle ReportChanges will increase total bundle size by 56 bytes ⬆️
|
iamrajjoshi
approved these changes
Jun 17, 2024
scttcper
approved these changes
Jun 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an organization changes their slug we should redirect to the new slug. This isn't working currently because of changes to OrganizationDetails that elide
featuresby default. (#71791)As customer-domains will soon be retried and replaced with a system configuration feature flag, I've chosen to adapt the logic for org details settings to read from
ConfigStorelike it will in the future.Fixes HC-1096