Skip to content

Conversation

@gggritso
Copy link
Member

Sibling to #71821 but on the backend. Basically, disable the Aggregate Span Waterfall and Span Duration Comparison features if the organization doesn't have access to Insights modules (AKA span metrics!)

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 31, 2024
@codecov
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (36312a7) to head (aba1bdd).
Report is 17 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #71823      +/-   ##
==========================================
+ Coverage   72.59%   77.91%   +5.31%     
==========================================
  Files        6562     6557       -5     
  Lines      292268   292165     -103     
  Branches    50485    50453      -32     
==========================================
+ Hits       212175   227640   +15465     
+ Misses      73722    58273   -15449     
+ Partials     6371     6252     -119     
Files Coverage Δ
...sentry/api/endpoints/organization_event_details.py 91.13% <100.00%> (ø)
...ry/api/endpoints/organization_spans_aggregation.py 93.18% <100.00%> (+1.13%) ⬆️

... and 994 files with indirect coverage changes

@gggritso gggritso marked this pull request as ready for review May 31, 2024 19:21
@gggritso gggritso requested a review from a team May 31, 2024 19:21
Copy link
Member

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gggritso gggritso merged commit 3946be4 into master Jun 4, 2024
@gggritso gggritso deleted the feat/insights/granular-backend-feature-flags branch June 4, 2024 14:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants