feat(insights): Granular frontend feature flags #71821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to see aggregate spans you need _some_ amount of span metrics. So, `insights-initial-modules` is a good fit here.
github-actions
bot
added
Scope: Frontend
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71821 +/- ##
==========================================
- Coverage 77.92% 77.92% -0.01%
==========================================
Files 6563 6563
Lines 292382 292384 +2
Branches 50500 50505 +5
==========================================
- Hits 227849 227846 -3
- Misses 58284 58288 +4
- Partials 6249 6250 +1
|
Bundle ReportChanges will decrease total bundle size by 7.64kB ⬇️
|
gggritso
removed
the
Scope: Backend
gggritso
changed the title
Member
Author
|
Reverted because a few organization lost access to Requests modules as a result of this. Will re-create when we figure out what was missing. |
Contributor
|
PR reverted: 5d78a21 |
getsentry-bot
added a commit
that referenced
this pull request
Jun 4, 2024
This reverts commit 23f44b7. Co-authored-by: gggritso <[email protected]>
gggritso
added a commit
that referenced
this pull request
Jun 4, 2024
Re-creation of #71821 which I had to fast-revert
gggritso
added a commit
that referenced
this pull request
Jun 4, 2024
Sibling to #71821 but on the backend. Basically, disable the Aggregate Span Waterfall and Span Duration Comparison features if the organization doesn't have access to Insights modules (AKA span metrics!)
hubertdeng123
added a commit
that referenced
this pull request
Jun 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spans-first-uiflag is going away, in favour of three flags:insights-entry-pointswhich enables entry points to Insight UIs if those entry points have upsells (e.g., sidebar links)insights-initial-modulesenables access to UIs that connect to the first set of Insights modules (Queries, Requests, Resources, etc.)insights-addon-modulesenables access to UI that show the newer set of Insights modules (Caches, LLMs, etc.)This PR gets rid of
spans-first-uichecks on the frontend, replacing them with the rightinsights-flag.