Skip to content

Conversation

@hubertdeng123
Copy link
Member

Take 3 of #71948. The PR that originally introduced sidebar changes was reverted, causing frontend tests that were introduced here to fail.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 4, 2024
@codecov
Copy link

codecov bot commented Jun 4, 2024

Bundle Report

Changes will increase total bundle size by 134 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.89MB 134 bytes ⬆️

@hubertdeng123 hubertdeng123 marked this pull request as ready for review June 4, 2024 16:21
@hubertdeng123 hubertdeng123 requested a review from a team June 4, 2024 16:21
@hubertdeng123
Copy link
Member Author

@gggritso I've noticed you've recently been working on sidebar changes, and wanted to loop you in as I've improved some of the test coverage here.

@codecov
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (51ccc1d) to head (c785ff8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #72012   +/-   ##
=======================================
  Coverage   77.91%   77.91%           
=======================================
  Files        6573     6573           
  Lines      292701   292702    +1     
  Branches    50523    50523           
=======================================
+ Hits       228053   228059    +6     
+ Misses      58401    58396    -5     
  Partials     6247     6247           
Files Coverage Δ
static/app/components/sidebar/index.tsx 80.71% <100.00%> (+1.57%) ⬆️

... and 2 files with indirect coverage changes

@hubertdeng123 hubertdeng123 merged commit 41087cc into master Jun 4, 2024
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/errors-only-sh-sidebar branch June 4, 2024 18:48
@sentry
Copy link

sentry bot commented Jun 4, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'pathname') Sidebar(index.tsx) View Issue
  • ‼️ TypeError: Cannot read properties of undefined (reading 'pathname') Sidebar(index.tsx) View Issue
  • ‼️ TypeError: Cannot read properties of undefined (reading 'pathname') Sidebar(index.tsx) View Issue
  • ‼️ TypeError: Cannot read properties of undefined (reading 'pathname') Sidebar(index.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

gggritso added a commit that referenced this pull request Jun 5, 2024
Follow-up to #72012. Updates the
tests a bit, moves things around, and expands test coverage.

- Move link set tests together

- Simplify `ConfigStore` init
    
    - init in `beforeEach`
    - remove `act`

- Update spec structure
    
    1. Set up all possible sidebar feature flags
    2. Await `Broadcast` mount
    3. Fetch elements by role, not by ID
    4. Check element by accessible title, not by ID
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants