Skip to content

feat(self-hosted): Errors only self-hosted sidebar #71948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 3, 2024
Merged

feat(self-hosted): Errors only self-hosted sidebar #71948

merged 10 commits into from
Jun 3, 2024

Conversation

@hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jun 3, 2024

a duplicate of #71787, but that one failed since a change to the sidebar file made it into master right before that one did

@hubertdeng123 hubertdeng123 requested a review from a team June 3, 2024 21:24
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 3, 2024
@codecov
Copy link

codecov bot commented Jun 3, 2024

Bundle Report

Changes will increase total bundle size by 134 bytes ⬆️

Bundle name Size Change
app-webpack-bundle-array-push 27.9MB 134 bytes ⬆️

@codecov
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.92%. Comparing base (d854a17) to head (fcc1442).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #71948      +/-   ##
==========================================
+ Coverage   74.64%   77.92%   +3.27%     
==========================================
  Files        6564     6562       -2     
  Lines      292378   292120     -258     
  Branches    50507    50465      -42     
==========================================
+ Hits       218245   227624    +9379     
+ Misses      67606    58197    -9409     
+ Partials     6527     6299     -228
Files Coverage Δ
static/app/components/sidebar/index.tsx 80.71% <100.00%> (+80.71%) ⬆️

... and 642 files with indirect coverage changes

@hubertdeng123 hubertdeng123 merged commit d495519 into master Jun 3, 2024
@hubertdeng123 hubertdeng123 deleted the hubertdeng123/errors-only-sh-sidebar branch June 3, 2024 21:47
@armenzg armenzg added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Jun 4, 2024
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jun 4, 2024

PR reverted: 0f8f390

getsentry-bot added a commit that referenced this pull request Jun 4, 2024
@getsentry-bot @armenzg
Revert "feat(self-hosted): Errors only self-hosted sidebar (#71948)"
0f8f390 
This reverts commit d495519.

Co-authored-by: armenzg <[email protected]>
@hubertdeng123 hubertdeng123 restored the hubertdeng123/errors-only-sh-sidebar branch June 4, 2024 15:52
@hubertdeng123 hubertdeng123 mentioned this pull request Jun 4, 2024
Merged
hubertdeng123 added a commit that referenced this pull request Jun 4, 2024
@hubertdeng123
feat(self-hosted): Errors only self-hosted sidebar (#72012)
41087cc 
Take 3 of #71948. The
[PR](#71821) that originally
introduced sidebar changes was reverted, causing frontend tests that
were introduced here to fail.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@azaslavsky azaslavsky azaslavsky approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hubertdeng123 @getsentry-bot @azaslavsky @armenzg