ref(related_issues): Make the code a bit more clear #71999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
armenzg
commented
Jun 4, 2024
| const {oneOtherIssueEvent} = useTraceTimelineEvents({ | ||
| event, | ||
| }); | ||
| const readyToShow = !isLoading && !isError; |
Member
Author
There was a problem hiding this comment.
This condition is not really necessary as you will see below.
| {isRelatedIssuesEnabled && readyToShow && oneOtherIssueEvent === undefined && ( | ||
| <TraceLink event={event} /> | ||
| )} | ||
| {isRelatedIssuesEnabled && oneOtherIssueEvent && ( |
Member
Author
There was a problem hiding this comment.
If oneOtherIssueEvent is defined, we know that the data was fetched and that there was no error.
| return ( | ||
| <StyledDataSection> | ||
| <GroupEventCarousel group={group} event={event} projectSlug={project.slug} /> | ||
| {isRelatedIssuesEnabled && readyToShow && oneOtherIssueEvent === undefined && ( |
Member
Author
There was a problem hiding this comment.
Moving this block closer to <TraceTimeline> since they would be shown together.
Bundle ReportChanges will decrease total bundle size by 37 bytes ⬇️
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71999 +/- ##
===========================================
+ Coverage 56.90% 77.94% +21.04%
===========================================
Files 6562 6572 +10
Lines 292314 292600 +286
Branches 50471 50519 +48
===========================================
+ Hits 166330 228057 +61727
+ Misses 121241 58292 -62949
- Partials 4743 6251 +1508
|
evanpurkhiser
approved these changes
Jun 4, 2024
armenzg
added a commit
that referenced
this pull request
Jun 4, 2024
When fetching events, `oneOtherIssueEvent` is `undefined`, thus, we need to wait until we're certain that the fetch has been completed to prevent rendering twice or the wrong state. I introduced this problem in #71999.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.