Skip to content

fix(query-builder): Remove [me,my_teams,none] suggestion from assigned #72915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix(query-builder): Remove [me,my_teams,none] suggestion from assigned #72915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions static/app/utils/withIssueTags.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,16 @@ function withIssueTags<Props extends WithIssueTagsProps>(
.filter(team => !team.isMember)
.map(team => `#${team.slug}`);

const meAndMyTeamsNone = ['my_teams', 'none', '[me, my_teams, none]'];
const suggestedAssignees: string[] = ['me', ...meAndMyTeamsNone, ...userTeams];
const suggestedAssignees: string[] = [
'me',
'my_teams',
'none',
// New search builder only works with single value suggestions
...(props.organization.features.includes('issue-stream-search-query-builder')
? []
: ['[me, my_teams, none]']),
...userTeams,
];
const assigndValues: SearchGroup[] | string[] = [
{
title: t('Suggested Values'),
Expand Down Expand Up @@ -96,7 +104,7 @@ function withIssueTags<Props extends WithIssueTagsProps>(
values: assigndValues,
},
};
}, [teams, members, tags]);
}, [members, teams, props.organization.features, tags]);

// Listen to tag store updates and cleanup listener on unmount
useEffect(() => {
Expand Down