Skip to content

ref: remove remote_subscriptions migrations #92004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

ref: remove remote_subscriptions migrations #92004

merged 1 commit into from
May 21, 2025

Conversation

@asottile-sentry
Copy link
Contributor

@asottile-sentry asottile-sentry commented May 21, 2025

this is a noop now and after the last hard stop already

@asottile-sentry asottile-sentry requested review from a team as code owners May 21, 2025 02:28
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 21, 2025
@codecov
Copy link

codecov bot commented May 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

⚠️ Parser warning

The parser emitted a warning. Please review your JUnit XML file:

Warning while parsing testcase attributes: Limit of string is 1000 chars, for name, we got 2083 at 1:157236 in /home/runner/work/sentry/sentry/.artifacts/pytest.junit.xml
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #92004   +/-   ##
=======================================
  Coverage   87.63%   87.63%           
=======================================
  Files       10361    10358    -3     
  Lines      587521   587497   -24     
  Branches    22594    22594           
=======================================
- Hits       514852   514843    -9     
+ Misses      72248    72233   -15     
  Partials      421      421

@asottile-sentry asottile-sentry force-pushed the asottile-rm-remote-subscriptions-migrations branch from b96ffda to ffffb57 Compare May 21, 2025 02:39
@asottile-sentry asottile-sentry force-pushed the asottile-rm-remote-subscriptions-migrations branch from 67f224f to fd9a6f2 Compare May 21, 2025 02:45
@asottile-sentry asottile-sentry force-pushed the asottile-rm-remote-subscriptions-migrations branch from fd9a6f2 to 74253b9 Compare May 21, 2025 13:23
@asottile-sentry asottile-sentry enabled auto-merge (squash) May 21, 2025 13:23
@vgrozdanic
Copy link
Member

vgrozdanic commented May 21, 2025

Shouldn't this app (remote_subscriptions) also be removed from MIGRATIONS_LOCKFILE_APP_WHITELIST in src/sentry/conf/server.py?

@asottile-sentry
Copy link
Contributor Author

asottile-sentry commented May 21, 2025

Shouldn't this app (remote_subscriptions) also be removed from MIGRATIONS_LOCKFILE_APP_WHITELIST in src/sentry/conf/server.py?

yes true

@asottile-sentry
ref: remove remote_subscriptions migrations
3a0894f 
this is a noop now and after the last hard stop already
@asottile-sentry asottile-sentry force-pushed the asottile-rm-remote-subscriptions-migrations branch from 74253b9 to 3a0894f Compare May 21, 2025 13:32
@asottile-sentry asottile-sentry merged commit 99640c2 into master May 21, 2025
59 checks passed
@asottile-sentry asottile-sentry deleted the asottile-rm-remote-subscriptions-migrations branch May 21, 2025 13:52
andrewshie-sentry pushed a commit that referenced this pull request Jun 2, 2025
@asottile-sentry @andrewshie-sentry
ref: remove remote_subscriptions migrations (#92004)
43d9a53 
this is a noop now and after the last hard stop already

<!-- Describe your PR here. -->
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vgrozdanic vgrozdanic vgrozdanic approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@asottile-sentry @vgrozdanic