Remove File-based EventAttachment code
#93804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Already 17 months ago in #62318, I switched the `EventAttachment` code over from using the `file_id` and django `File`-models to storing things in filestore (the go service) directly via the `blob_path`. As attachments have a 30 day TTL, it is high time to remove the backwards compatibility code.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #93804 +/- ##
==========================================
- Coverage 88.02% 88.02% -0.01%
==========================================
Files 10331 10331
Lines 596378 596378
Branches 23160 23160
==========================================
- Hits 524976 524960 -16
- Misses 70946 70962 +16
Partials 456 456 |
Swatinem
force-pushed
the
swatinem/rm-eventattachment-fileid-part1
branch
from
87208ad to
1aa35a4
Compare
Swatinem
force-pushed
the
swatinem/rm-eventattachment-fileid-part1
branch
from
1aa35a4 to
86da06d
Compare
Swatinem
force-pushed
the
swatinem/rm-eventattachment-fileid-part1
branch
from
86da06d to
27ebb34
Compare
jan-auer
approved these changes
Jun 18, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jun 19, 2025
Already 17 months ago in #62318, I switched the `EventAttachment` code over from using the `file_id` and django `File`-models to storing things in filestore (the go service) directly via the `blob_path`. As attachments have a 30 day TTL, it is high time to remove the backwards compatibility code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already 17 months ago in #62318, I switched the
EventAttachmentcode over from using thefile_idand djangoFile-models to storing things in filestore (the go service) directly via theblob_path.As attachments have a 30 day TTL, it is high time to remove the backwards compatibility code.
Ref FS-49