Skip to content

Added mesh shading spec #7885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 9, 2025
Merged

Added mesh shading spec #7885

merged 13 commits into from
Jul 9, 2025

Conversation

@inner-daemons
Copy link
Collaborator

@inner-daemons inner-daemons commented Jul 6, 2025 •
edited
Loading

Connections
#7197

Description
Previously all work for mesh shading was based on this comment. This moves it to a proper spec that lives in the wgpu repo.

Note that it currently references a folder created in #7345, which hasn't yet been merged. This shouldn't block a merge in my opinion.

Testing

Squash or Rebase?
Squash

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy --tests. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • If this contains user-facing changes, add a CHANGELOG.md entry.

@inner-daemons inner-daemons mentioned this pull request Jul 6, 2025
Open
37 tasks
@inner-daemons inner-daemons marked this pull request as ready for review July 6, 2025 20:21
@inner-daemons inner-daemons requested a review from a team as a code owner July 6, 2025 20:21
@inner-daemons inner-daemons marked this pull request as draft July 8, 2025 17:25
@inner-daemons inner-daemons marked this pull request as ready for review July 9, 2025 20:12
cwfitzgerald
cwfitzgerald approved these changes Jul 9, 2025
View reviewed changes
Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small nits, good to land afterwards. Glad to have some more documentation!

@inner-daemons
Copy link
Collaborator Author

@cwfitzgerald Should all be resolved now, thanks!

@cwfitzgerald
Copy link
Member

Quality stuff!

@cwfitzgerald cwfitzgerald merged commit 13fec87 into gfx-rs:trunk Jul 9, 2025
40 checks passed
@inner-daemons inner-daemons deleted the mesh-shading/wgsl-spec branch September 11, 2025 17:43
sharmajai pushed a commit to sharmajai/wgpu that referenced this pull request Oct 12, 2025
@inner-daemons @cwfitzgerald @sharmajai
Added mesh shading spec (gfx-rs#7885)
6754043 
Co-authored-by: Connor Fitzgerald <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cwfitzgerald cwfitzgerald Awaiting requested review from cwfitzgerald

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@inner-daemons @cwfitzgerald