This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Incorporate feedback from shana's inline-comments PR review #1037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed `if (`.
It implements IDisposable without the ceremony. ;-)
grokys
approved these changes
Jul 7, 2017
| if (mergeBase == null) | ||
| { | ||
| throw new FileNotFoundException($"Couldn't find merge base between {baseSha} and {headSha}."); | ||
| throw new InvalidOperationException($"Couldn't find merge base between {baseSha} and {headSha}."); |
There was a problem hiding this comment.
In #1036, I changed this to LibGit2Sharp.NotFoundException so might be worth reverting this change until that's merged to prevent merge conflicts.
Will be fixed in a different PR. This reverts commit 1744375.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of little things.