This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Using different inline comment & annotation markers #2084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 271c2cd.
StanleyGoldman
changed the title
StanleyGoldman
changed the base branch from
features/check-suite-annotations
to
master
|
Here's where I've landed on this one: When there is a comment
When there is an annotation
Both
I landed on using rectangle since it's close to how inline annotations look like and being able to stack them vertically helped communicate that there are "more than one" types of annotations and comments. We could consider utilizing more colors to indicate the type of annotation (instead of me sticking with one color for all annotations.) |
|
Pushed a few commits that tries a different approach to markers When there is a comment
When there is an annotation
Both
|
|
Pushed a commit that updates the colors of the annotation markers
@StanleyGoldman I'm going to remove my assignment, but let me know if I should take a look at anything else. |
StanleyGoldman
changed the title
grokys
approved these changes
Nov 30, 2018
StanleyGoldman
deleted the
features/check-suite-annotations-inline-markers
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds functionality to display a different inline glyph in different situations.