Check Run Annotations #1864

StanleyGoldman · 2018-08-16T12:26:48Z

This pull request adds functionality to:

Show a clickable indicator on pull request checks that have annotations
Show a list of annotations on a pull request
Show a count of annotation failures, warnings and notices in a pull request file list.

Remaining

Design work

Before merging

merge Check Run Annotations Inline #1900 into this branch/PR

Images

…tions

StanleyGoldman · 2018-08-16T12:31:00Z

@donokuda... send 💕

…e annotations

…tions

…tions # Conflicts: # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

…tions # Conflicts: # src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs # src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml

…tions # Conflicts: # src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

…tions

…e-annotations

…hub.com/github/VisualStudio into features/check-suite-annotations-inline

Update inline review / annotation margin glyph

…eck-suite-annotations

…uite-annotations-inline

…-inline-available-for-comment Check Run Annotations should be able to disable the Add Comment functionality

…uite-annotations-inline

…-inline Check Run Annotations Inline

grokys

test

grokys · 2018-11-26T18:23:28Z

src/GitHub.Exports/Models/CheckRunModel.cs

        public DateTimeOffset? CompletedAt { get; set; }

-        /// <summary>The name of the check for this check run.</summary>
+        /// <summary>


grokys · 2018-11-26T18:26:47Z

Couple of things I've noticed with the commenting behavior after this PR:

Is it intended that both comments and annotations now get a grey diamond icon in the margin? I'd have expected the icon to distinguish between comments and annotations
There's now a vertical scrollbar in the comment box that scrolls one pixel

…/github/VisualStudio into features/check-suite-annotations

This might help with visually grouping comment threads in the future

donokuda · 2018-11-27T00:15:15Z

Is it intended that both comments and annotations now get a grey diamond icon in the margin? I'd have expected the icon to distinguish between comments and annotations

This was intended. I was exploring different ways of indicating if a line had an annotation, a comment, both, and what kind of annotation. Here's a crop of a work-in-progress mockup:

The challenge I ran into was how to represent more than one annotation marker in the margin and decided on one to show to simplify things. However, I'll work on iterating in @StanleyGoldman's pull request for using different markers.

donokuda · 2018-11-27T00:22:00Z

Heads up, I pushed a change that removed some border lines between comments. My (future) intent is to group comment threads together and removing borders will make this easier visibly.

grokys · 2018-11-27T07:46:21Z

Ok, thanks for the details @donokuda - I've merged this, lets iterate on it in separate PRs. Those mockups look great!

StanleyGoldman added 4 commits August 15, 2018 14:10

Restoring Annotations

2fa267a

Moving more FromGraphQl functions

182a9a9

Merge branch 'features/check-suites' into features/check-suite-annota…

4383c27

…tions

Functionality to indicate Check Run annotation counts

1f324a7

StanleyGoldman added the WIP label Aug 16, 2018

StanleyGoldman assigned StanleyGoldman and donokuda Aug 16, 2018

StanleyGoldman added 12 commits August 16, 2018 09:06

Attempting to display an icon for PullRequestCheckViewModels that hav…

d9b6fe5

…e annotations

Merge branch 'features/check-suites' into features/check-suite-annota…

fafc68f

…tions

Merge branch 'features/check-suites' into features/check-suite-annota…

10aee41

…tions

Displaying an icon next to check runs with annotations

220a3e9

Tweaking min width

3409360

Merge branch 'features/check-suites' into features/check-suite-annota…

47bc9f1

…tions # Conflicts: # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Adding a display for PullRequest Annotations

68a1d12

Functionality to display annotations in a dedicated view

317c4ae

Fixing error

86feafd

Fixing formatting

cc4219a

Adding different types of inline tags

8fb18b4

Merge branch 'features/check-suites' into features/check-suite-annota…

95d0079

…tions # Conflicts: # src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs # src/GitHub.VisualStudio/Views/GitHubPane/PullRequestCheckView.xaml

StanleyGoldman force-pushed the features/check-suite-annotations branch from c7ba7d6 to 95d0079 Compare August 20, 2018 19:38

StanleyGoldman added 2 commits August 21, 2018 07:22

Merge branch 'features/check-suites' into features/check-suite-annota…

42be1cd

…tions # Conflicts: # src/GitHub.App/ViewModels/GitHubPane/PullRequestCheckViewModel.cs # src/GitHub.InlineReviews/Services/PullRequestSessionService.cs

Merge branch 'features/check-suites' into features/check-suite-annota…

966c955

…tions

meaghanlewis added this to the 2.5.6 milestone Aug 21, 2018

StanleyGoldman added 2 commits August 22, 2018 11:34

Displaying inline glyphs

7ee9e5a

Merge branch 'master' into features/check-suite-annotations

9ae3a85

StanleyGoldman changed the title ~~[WIP] Check Suite Annotations~~ [WIP] Check Run Annotations Aug 22, 2018

StanleyGoldman changed the base branch from features/check-suites to master August 22, 2018 15:59

StanleyGoldman added 2 commits August 31, 2018 17:51

Merge remote-tracking branch 'origin/master' into features/check-suit…

662f21e

…e-annotations

Fix needed after merge

a069d8d

donokuda and others added 17 commits November 21, 2018 11:17

Merge branch 'features/check-suite-annotations-inline' of https://git…

adfada0

…hub.com/github/VisualStudio into features/check-suite-annotations-inline

It's a circle now!

e9080ab

Update color

747084c

It's a lil diamond now

a0e2fcd

Adding additional Check Run fields

0d81d7c

Make everything a diamond

c67c5b4

Fix bottom margin for reply textbox

c110ad9

Using only one view

271c2cd

Merge pull request #2077 from github/donokuda/polish-annotation-margin

4069376

Update inline review / annotation margin glyph

Merge remote-tracking branch 'remotes/origin/master' into features/ch…

c2d7d72

…eck-suite-annotations

Merge branch 'features/check-suite-annotations' into features/check-s…

fe6c09d

…uite-annotations-inline

Attempting to control the comment ability

f13d354

Correcting the xaml binding

f3c4548

Merge pull request #2080 from github/features/check-suite-annotations…

ce065dc

…-inline-available-for-comment Check Run Annotations should be able to disable the Add Comment functionality

Merge branch 'master' into features/check-suite-annotations

9e9978f

Merge branch 'features/check-suite-annotations' into features/check-s…

1da4ac2

…uite-annotations-inline

Merge pull request #1900 from github/features/check-suite-annotations…

fef4a16

…-inline Check Run Annotations Inline

grokys reviewed Nov 26, 2018

View reviewed changes

StanleyGoldman and others added 4 commits November 26, 2018 13:47

Removing margin

e249664

no margins

a6f67e8

Merge branch 'features/check-suite-annotations' of https://github.com…

cd33156

…/github/VisualStudio into features/check-suite-annotations

remove border from comments

6bbb1ae

This might help with visually grouping comment threads in the future

grokys approved these changes Nov 27, 2018

View reviewed changes

grokys merged commit 9124705 into master Nov 27, 2018

StanleyGoldman deleted the features/check-suite-annotations branch November 27, 2018 12:31

StanleyGoldman mentioned this pull request Dec 3, 2018

Fixes to locate inline tags #2099

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Check Run Annotations #1864

Check Run Annotations #1864

Uh oh!

StanleyGoldman commented Aug 16, 2018 •

edited

Loading

Uh oh!

StanleyGoldman commented Aug 16, 2018

Uh oh!

grokys left a comment

Uh oh!

grokys Nov 26, 2018

Uh oh!

grokys commented Nov 26, 2018

Uh oh!

donokuda commented Nov 27, 2018

Uh oh!

donokuda commented Nov 27, 2018

Uh oh!

grokys commented Nov 27, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Check Run Annotations #1864

Check Run Annotations #1864

Uh oh!

Conversation

StanleyGoldman commented Aug 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Remaining

Before merging

Images

Uh oh!

StanleyGoldman commented Aug 16, 2018

Uh oh!

grokys left a comment

Choose a reason for hiding this comment

Uh oh!

grokys Nov 26, 2018

Choose a reason for hiding this comment

Uh oh!

grokys commented Nov 26, 2018

Uh oh!

donokuda commented Nov 27, 2018

Uh oh!

donokuda commented Nov 27, 2018

Uh oh!

grokys commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

StanleyGoldman commented Aug 16, 2018 •

edited

Loading

grokys commented Nov 27, 2018 •

edited

Loading