Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Conversation

StanleyGoldman
Copy link
Contributor

Before this pull request:

  1. Previous Comment works. Next Comment does not work.
  2. Opening an annotation by clicking the link in the pull request file list consistently opens the second annotation in the file, not the first.

Fixes:

  1. As part of Check Run Annotations #1864, NextInlineCommand.cs(56) was changed from > to >=. This was returned to it's previous state.
  2. A fix was made to correct the annotation line number sent to EditorService.OpenDiff. Comments were added to explain the changes.

@StanleyGoldman StanleyGoldman force-pushed the fixes/locating-annotations branch from 9625ae8 to 3b0f306 Compare December 3, 2018 21:26
@meaghanlewis
Copy link
Contributor

Tested and this LGTM. Thanks for fixing.

Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! It can be super confusing Visual Studio using 1-based line numbers some GitHub APIs using 0-based! 😖

@jcansdale jcansdale merged commit 7db8896 into master Dec 4, 2018
@jcansdale jcansdale deleted the fixes/locating-annotations branch December 4, 2018 11:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants